From: Thomas Huth <thuth@redhat.com>
To: Tudor Gheorghiu <tudor.reda@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] replace error_setg(&error_fatal, ...) with error_report()
Date: Tue, 8 Oct 2024 09:04:47 +0200 [thread overview]
Message-ID: <71387c81-b0ef-44c8-8f94-9a9db4af5a0d@redhat.com> (raw)
In-Reply-To: <ZwRgbNs4Hz-Drt2V@redaops>
On 08/10/2024 00.27, Tudor Gheorghiu wrote:
> According to include/qapi/error.h:
> * Please don't error_setg(&error_fatal, ...), use error_report() and
> * exit(), because that's more obvious.
>
> Patch updates all instances of error_setg(&error_fatal, ...) with
> error_report(...), adds the explicit exit(1) and removes redundant
> return statements.
>
> Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2587
> ---
> hw/arm/allwinner-a10.c | 5 +++--
> hw/arm/allwinner-h3.c | 4 ++--
> hw/arm/allwinner-r40.c | 4 ++--
> hw/arm/xlnx-versal-virt.c | 4 ++--
> hw/audio/soundhw.c | 3 ++-
> system/vl.c | 3 ++-
> 6 files changed, 13 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-10-08 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 22:27 [PATCH] replace error_setg(&error_fatal, ...) with error_report() Tudor Gheorghiu
2024-10-08 7:04 ` Thomas Huth [this message]
2024-10-18 16:30 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71387c81-b0ef-44c8-8f94-9a9db4af5a0d@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tudor.reda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.