From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L5T0z-0002cF-7e
	for qemu-devel@nongnu.org; Wed, 26 Nov 2008 17:37:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L5T0w-0002c3-NR
	for qemu-devel@nongnu.org; Wed, 26 Nov 2008 17:37:43 -0500
Received: from [199.232.76.173] (port=47239 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L5T0w-0002by-Hl
	for qemu-devel@nongnu.org; Wed, 26 Nov 2008 17:37:42 -0500
Received: from web51101.mail.re2.yahoo.com ([206.190.38.143]:34877)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <theburner1@yahoo.com>) id 1L5T0w-0001LT-8G
	for qemu-devel@nongnu.org; Wed, 26 Nov 2008 17:37:42 -0500
Date: Wed, 26 Nov 2008 14:37:41 -0800 (PST)
From: Justin Chevrier <theburner1@yahoo.com>
Subject: Re: [Qemu-devel] [PATCH] LSI53C895A: Do not update current_dma_len
	with dbc in TIA mode
In-Reply-To: <20081126221450.GP31893@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Message-ID: <714315.59707.qm@web51101.mail.re2.yahoo.com>
Reply-To: theburner1@yahoo.com, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>

Ryan Harper wrote:
> Do you also have SCSI debug on in scsi-disk.c ?  I'd
> really like to see
> the scsi command that was generating the read with lengh
> 69632.
> 
> Actually, have you tried this since the 40 bit DMA patch
> was included?

I'm running head.

The command is a Read:

scsi-disk: Command: lun=0 tag=0x1003b data=0x28 0x00 0x00 0x5a 0x81 0x57 0x00 0x00 0x88 0x00
scsi-disk: Read (sector 5931351, count 136)
scsi-disk: Read sector_count=136

The 69632 is coming from 136 * 512

> Yeah, I think for now, the right thing to do is revert the
> old patch
> until we figure how to handle this correctly for both test
> cases.

This reverts the relevant section of the original patch:

--- hw/lsi53c895a.c     (revision 5799)
+++ hw/lsi53c895a.c     (working copy)
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;