From: David Howells <dhowells@redhat.com>
To: john stultz <johnstul@us.ibm.com>
Cc: dhowells@redhat.com, lkml <linux-kernel@vger.kernel.org>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
linux-am33-list@redhat.com
Subject: Re: [RFC][PATCH 11/14] Convert mn10300 to read/update_persistent_clock
Date: Tue, 05 Jan 2010 17:08:56 +0000 [thread overview]
Message-ID: <7145.1262711336@redhat.com> (raw)
In-Reply-To: <1261541567.3508.73.camel@localhost.localdomain>
john stultz <johnstul@us.ibm.com> wrote:
> This patch converts the mn10300 architecture to use the generic
> read_persistent_clock and update_persistent_clock interfaces, reducing
> the amount of arch specific code we have to maintain, and allowing for
> further cleanups in the future.
>
> I have not built or tested this patch, so help from arch maintainers
> would be appreciated.
>
> Signed-off-by: John Stultz <johnstul@us.ibm.com>
arch/mn10300/kernel/rtc.c: In function `update_persistent_clock':
arch/mn10300/kernel/rtc.c:113: error: implicit declaration of function 'set_rtc_mms'
arch/mn10300/kernel/rtc.c: At top level:
arch/mn10300/kernel/rtc.c:24: warning: unused variable `last_rtc_update'
arch/mn10300/kernel/rtc.c:24: warning: 'last_rtc_update' defined but not used
arch/mn10300/kernel/rtc.c:51: warning: 'set_rtc_mmss' defined but not used
set_rtc_mms should be set_rtc_mmss in update_persistent_clock(). In fact,
set_rtc_mmss() should probably just be rolled into update_persistent_clock().
Furthermore, last_rtc_update and its comment should be deleted.
Apart from that, it seems to work.
David
next prev parent reply other threads:[~2010-01-05 17:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 3:59 [RFC][PATCH 0/14] Convert remaining arches to read/update_persistent_clock john stultz
2009-12-23 4:00 ` [RFC][PATCH 1/14] Convert alpha " john stultz
2009-12-23 4:01 ` [RFC][PATCH 2/14] Convert arm " john stultz
2009-12-23 4:01 ` john stultz
2009-12-23 4:03 ` [RFC][PATCH 3/14] Convert avr32 " john stultz
2009-12-23 4:04 ` [RFC][PATCH 4/14] Convert blackfin " john stultz
2009-12-23 4:05 ` [RFC][PATCH 5/14] Convert cris " john stultz
2009-12-23 4:06 ` [RFC][PATCH 6/14] Convert frv " john stultz
2009-12-23 4:08 ` [RFC][PATCH 7/14] Convert h8300 " john stultz
2009-12-23 4:09 ` [RFC][PATCH 8/14] Convert ia64 " john stultz
2009-12-23 4:09 ` john stultz
2009-12-23 4:10 ` [RFC][PATCH 9/14] Convert m32r " john stultz
2009-12-23 4:11 ` [RFC][PATCH 10/14] Convert m68k " john stultz
2009-12-23 4:11 ` john stultz
2009-12-23 4:12 ` [RFC][PATCH 11/14] Convert mn10300 " john stultz
2009-12-23 4:14 ` [RFC][PATCH 12/14] Convert parisc " john stultz
2009-12-23 4:14 ` john stultz
2009-12-23 4:15 ` [RFC][PATCH 13/14] Convert sh " john stultz
2009-12-23 4:15 ` john stultz
2009-12-23 4:16 ` [RFC][PATCH 14/14] Convert sparc " john stultz
2009-12-23 4:16 ` john stultz
2009-12-24 4:52 ` [RFC][PATCH 14/14] Convert sparc to David Miller
2009-12-24 4:52 ` [RFC][PATCH 14/14] Convert sparc to read/update_persistent_clock David Miller
2010-01-05 16:41 ` Kristoffer Glembo
2010-01-05 16:41 ` Kristoffer Glembo
2010-01-05 17:08 ` David Howells [this message]
2010-01-05 16:47 ` [RFC][PATCH 6/14] Convert frv " David Howells
2009-12-24 11:09 ` [RFC][PATCH 2/14] Convert arm " Uwe Kleine-König
2009-12-24 11:09 ` Uwe Kleine-König
2009-12-23 5:08 ` [RFC][PATCH 0/14] Convert remaining arches " Paul Mundt
2009-12-23 5:08 ` Paul Mundt
2009-12-23 10:08 ` Geert Uytterhoeven
2009-12-23 10:08 ` [RFC][PATCH 0/14] Convert remaining arches to Geert Uytterhoeven
2009-12-23 22:04 ` [RFC][PATCH 0/14] Convert remaining arches to read/update_persistent_clock john stultz
2009-12-23 22:04 ` [RFC][PATCH 0/14] Convert remaining arches to john stultz
2009-12-24 0:27 ` [RFC][PATCH 0/14] Convert remaining arches to read/update_persistent_clock Dialup Jon Norstog
2009-12-24 0:27 ` Dialup Jon Norstog
2009-12-24 4:54 ` David Miller
2009-12-24 4:54 ` [RFC][PATCH 0/14] Convert remaining arches to David Miller
2009-12-24 5:10 ` [RFC][PATCH 0/14] Convert remaining arches to read/update_persistent_clock Paul Mundt
2009-12-24 5:10 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7145.1262711336@redhat.com \
--to=dhowells@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.