From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13346EB64D8 for ; Fri, 16 Jun 2023 13:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8JaLVvnbD9vNC/D04y9AA7KN9ozsAktJU8IuGPmFamU=; b=FKwRGurB111YAn AQHvf8311x2RS5bdZjFstkpfjO1H2dSOUUrgex7Err5VXCIz26Vh6mi72Bs79ATRw1wjGOaWfJg7t GIup/2Nu9unpLJcwheMopTLDVLJJRzB+EPa7rGa8E70NJMgME5h+iUGYbtg1/tYUJx6tuqAk+SH7m fvAfJenhrBltBY+jAfxvaXfHclTozZVtZl6HpS1nh3Ae7FUoAKhJLtCDSsfVJTrrZVlkGXHsNPguW JyjR0scrzT+0OqH/mpkkme7sXTtqBFoiD/OlwC7GuUFTVML5A8Ekf+Qtn1XMW56WoexR7grJ73n1O q95lGSp9AfgaqeCldWYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA9oX-000hqV-24; Fri, 16 Jun 2023 13:48:33 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA9oT-000hp4-24 for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 13:48:31 +0000 X-GND-Sasl: alexis.lothore@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686923305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8oK/JD/VfQBaYnT9KJx8BUomsRwXIR/Wq47zzH/xURI=; b=N95uKDkFRvrLUoacdiLx3mrcBstb+8fwzdVsf2ul7uf6Ax64ehU/HuBfHioTUQcfai6VdU QwWC6u36IDmXlt5k2bwHon2DQo6M+6hGsv5SI0s4cnNnhHxYWbqtb5uQDl8vlNcZl7M5Ys yJGDB8+0+hmhrF+Im+MswNcoH7a7Od/7ytGcjOSSFddRP6HI/C8zFDDXUjQZ6iAzRtLk4k CddbTmcvec/b2kFDxlFnPJmRiwjw8z27pXSbRLm/erjIHp5vdUW2uuKBJXVeZKt94/gqYj 9ytK2pvllhb7xJ3erhfBiNnX0Ui+FN5TQaCxqRLEC/4YNaaRhwbK6qk1BrREog== X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id E9A18FF806; Fri, 16 Jun 2023 13:48:21 +0000 (UTC) Message-ID: <71492ab7-9d6b-e41c-e392-1bee04860f18@bootlin.com> Date: Fri, 16 Jun 2023 15:48:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH net-next 3/8] net: stmmac: move PTP interrupt handling to IP-specific DWMAC file To: Simon Horman Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Thomas Petazzoni , Nicolas Carrier References: <20230616100409.164583-1-alexis.lothore@bootlin.com> <20230616100409.164583-4-alexis.lothore@bootlin.com> Content-Language: en-US From: =?UTF-8?Q?Alexis_Lothor=c3=a9?= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_064829_943689_F8D1A505 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gU2ltb24sCgpPbiA2LzE2LzIzIDE1OjM0LCBTaW1vbiBIb3JtYW4gd3JvdGU6Cj4gT24g RnJpLCBKdW4gMTYsIDIwMjMgYXQgMTI6MDQ6MDRQTSArMDIwMCwgYWxleGlzLmxvdGhvcmVAYm9v dGxpbi5jb20gd3JvdGU6Cj4+IEZyb206IEFsZXhpcyBMb3Rob3LDqSA8YWxleGlzLmxvdGhvcmVA Ym9vdGxpbi5jb20+Cj4+Cj4+IEFzIGZvciBhdXhpbGlhcnkgc25hcHNob3QgdHJpZ2dlcnMgY29u ZmlndXJhdGlvbiwgcmVhZGluZyBzbmFwc2hvdHMgZGVwZW5kcwo+PiBvbiBzcGVjaWZpYyByZWdp c3RlcnMgYWRkcmVzc2VzIGFuZCBsYXlvdXQuIEFzIGEgY29uc2VxdWVuY2UsIG1vdmUKPj4gUFRQ LXNwZWNpZmljIHBhcnQgb2Ygc3RtbWFjIGludGVycnVwdCBoYW5kbGluZyB0byBzcGVjaWZpYyBE V01BQyBJUCBmaWxlCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFsZXhpcyBMb3Rob3LDqSA8YWxleGlz LmxvdGhvcmVAYm9vdGxpbi5jb20+Cj4gCj4gSGkgQWxleGlzLAo+IAo+IHRoYW5rcyBmb3IgeW91 ciBwYXRjaC4KPiAKPiAuLi4KPiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0 L3N0bWljcm8vc3RtbWFjL2R3bWFjNF9jb3JlLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1p Y3JvL3N0bW1hYy9kd21hYzRfY29yZS5jCj4+IGluZGV4IDAxYzA4MjJkMzdlNi4uYjM2ZmJiMGZh NWRhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9k d21hYzRfY29yZS5jCj4+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFj L2R3bWFjNF9jb3JlLmMKPiAKPiAuLi4KPiAKPj4gK3N0YXRpYyB2b2lkIGR3bWFjNF9wdHBfaXNy KHN0cnVjdCBzdG1tYWNfcHJpdiAqcHJpdikKPj4gK3sKPj4gKwl1MzIgbnVtX3NuYXBzaG90LCB0 c19zdGF0dXM7Cj4+ICsJc3RydWN0IHB0cF9jbG9ja19ldmVudCBldmVudDsKPj4gKwl1bnNpZ25l ZCBsb25nIGZsYWdzOwo+PiArCXU2NCBwdHBfdGltZTsKPj4gKwlpbnQgaTsKPiAKPiBQbGVhc2Ug dXNlIHJldmVyc2UgeG1hcyB0cmVlIC0gbG9uZ2VzdCBsaW5lIHRvIHNob3J0ZXN0IC0gZm9yIG5l dwo+IE5ldHdvcmtpbmcgY29kZS4KPiAKPiAJc3RydWN0IHB0cF9jbG9ja19ldmVudCBldmVudDsK PiAJdTMyIG51bV9zbmFwc2hvdCwgdHNfc3RhdHVzOwo+IAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ IAl1NjQgcHRwX3RpbWU7Cj4gCWludCBpOwo+IApBQ0sKPiAuLi4KPiAKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19wdHAuaCBiL2RyaXZl cnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19wdHAuaAo+PiBpbmRleCA5ZTBm ZjJjZWMzNTIuLjkyZWQ0MjE3MDJiOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJu ZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX3B0cC5oCj4+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVy bmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19wdHAuaAo+PiBAQCAtMjMsOSArMjMsNiBAQAo+PiAg I2RlZmluZQlQVFBfU1RTVVIJMHgxMAkvKiBTeXN0ZW0gVGltZSDigJMgU2Vjb25kcyBVcGRhdGUg UmVnICovCj4+ICAjZGVmaW5lCVBUUF9TVE5TVVIJMHgxNAkvKiBTeXN0ZW0gVGltZSDigJMgTmFu b3NlY29uZHMgVXBkYXRlIFJlZyAqLwo+PiAgI2RlZmluZQlQVFBfVEFSCQkweDE4CS8qIFRpbWVz dGFtcCBBZGRlbmQgUmVnICovCj4+IC0jZGVmaW5lCVBUUF9BQ1IJCTB4NDAJLyogQXV4aWxpYXJ5 IENvbnRyb2wgUmVnICovCj4gCj4gVW5mb3J0dW5hdGVseSB0aGlzIHNlZW1zIHRvIGJyZWFrIHRo ZSBidWlsZCBvZgo+IGRyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLWlu dGVsLmMKPiBvbiBhbiB4ODZfNjQgYWxsbG9kY29uZmlnLCBhcyBQVFBfQUNSIGlzIHVzZWQgaW4g dGhhdCBmaWxlLgo+IAo+PiAtI2RlZmluZQlQVFBfQVROUgkweDQ4CS8qIEF1eGlsaWFyeSBUaW1l c3RhbXAgLSBOYW5vc2Vjb25kcyBSZWcgKi8KPj4gLSNkZWZpbmUJUFRQX0FUU1IJMHg0YwkvKiBB dXhpbGlhcnkgVGltZXN0YW1wIC0gU2Vjb25kcyBSZWcgKi8KPj4gIAo+PiAgI2RlZmluZQlQVFBf U1ROU1VSX0FERFNVQl9TSElGVAkzMQo+PiAgI2RlZmluZQlQVFBfRElHSVRBTF9ST0xMT1ZFUl9N T0RFCTB4M0I5QUNBMDAJLyogMTBlOS0xIG5zICovCgpPdWNoLiB0aGFua3MgZm9yIHNwb3R0aW5n IHRoZSBpc3N1ZSBhbmQgdGhlIHByb3ZpZGluZyBidWlsZCBkZXRhaWxzLCBJJ2xsIGZpeAp0aGlz IGFuZCB3YWl0IGEgYml0IGZvciBtb3JlIGNvbW1lbnRzIGJlZm9yZSBzZW5kaW5nIHYyCj4gCj4g LS0KPiBwdy1ib3Q6IGNoYW5nZXMtcmVxdWVzdGVkCj4gCgotLSAKQWxleGlzIExvdGhvcsOpLCBC b290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290 bGluLmNvbQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B3CEB64DA for ; Fri, 16 Jun 2023 13:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344966AbjFPNsp (ORCPT ); Fri, 16 Jun 2023 09:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244629AbjFPNsd (ORCPT ); Fri, 16 Jun 2023 09:48:33 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F4763593; Fri, 16 Jun 2023 06:48:27 -0700 (PDT) X-GND-Sasl: alexis.lothore@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686923305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8oK/JD/VfQBaYnT9KJx8BUomsRwXIR/Wq47zzH/xURI=; b=N95uKDkFRvrLUoacdiLx3mrcBstb+8fwzdVsf2ul7uf6Ax64ehU/HuBfHioTUQcfai6VdU QwWC6u36IDmXlt5k2bwHon2DQo6M+6hGsv5SI0s4cnNnhHxYWbqtb5uQDl8vlNcZl7M5Ys yJGDB8+0+hmhrF+Im+MswNcoH7a7Od/7ytGcjOSSFddRP6HI/C8zFDDXUjQZ6iAzRtLk4k CddbTmcvec/b2kFDxlFnPJmRiwjw8z27pXSbRLm/erjIHp5vdUW2uuKBJXVeZKt94/gqYj 9ytK2pvllhb7xJ3erhfBiNnX0Ui+FN5TQaCxqRLEC/4YNaaRhwbK6qk1BrREog== X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com X-GND-Sasl: alexis.lothore@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id E9A18FF806; Fri, 16 Jun 2023 13:48:21 +0000 (UTC) Message-ID: <71492ab7-9d6b-e41c-e392-1bee04860f18@bootlin.com> Date: Fri, 16 Jun 2023 15:48:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH net-next 3/8] net: stmmac: move PTP interrupt handling to IP-specific DWMAC file To: Simon Horman Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Thomas Petazzoni , Nicolas Carrier References: <20230616100409.164583-1-alexis.lothore@bootlin.com> <20230616100409.164583-4-alexis.lothore@bootlin.com> Content-Language: en-US From: =?UTF-8?Q?Alexis_Lothor=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Simon, On 6/16/23 15:34, Simon Horman wrote: > On Fri, Jun 16, 2023 at 12:04:04PM +0200, alexis.lothore@bootlin.com wrote: >> From: Alexis Lothoré >> >> As for auxiliary snapshot triggers configuration, reading snapshots depends >> on specific registers addresses and layout. As a consequence, move >> PTP-specific part of stmmac interrupt handling to specific DWMAC IP file >> >> Signed-off-by: Alexis Lothoré > > Hi Alexis, > > thanks for your patch. > > ... > >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c >> index 01c0822d37e6..b36fbb0fa5da 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > ... > >> +static void dwmac4_ptp_isr(struct stmmac_priv *priv) >> +{ >> + u32 num_snapshot, ts_status; >> + struct ptp_clock_event event; >> + unsigned long flags; >> + u64 ptp_time; >> + int i; > > Please use reverse xmas tree - longest line to shortest - for new > Networking code. > > struct ptp_clock_event event; > u32 num_snapshot, ts_status; > unsigned long flags; > u64 ptp_time; > int i; > ACK > ... > >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> index 9e0ff2cec352..92ed421702b9 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> @@ -23,9 +23,6 @@ >> #define PTP_STSUR 0x10 /* System Time – Seconds Update Reg */ >> #define PTP_STNSUR 0x14 /* System Time – Nanoseconds Update Reg */ >> #define PTP_TAR 0x18 /* Timestamp Addend Reg */ >> -#define PTP_ACR 0x40 /* Auxiliary Control Reg */ > > Unfortunately this seems to break the build of > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > on an x86_64 alllodconfig, as PTP_ACR is used in that file. > >> -#define PTP_ATNR 0x48 /* Auxiliary Timestamp - Nanoseconds Reg */ >> -#define PTP_ATSR 0x4c /* Auxiliary Timestamp - Seconds Reg */ >> >> #define PTP_STNSUR_ADDSUB_SHIFT 31 >> #define PTP_DIGITAL_ROLLOVER_MODE 0x3B9ACA00 /* 10e9-1 ns */ Ouch. thanks for spotting the issue and the providing build details, I'll fix this and wait a bit for more comments before sending v2 > > -- > pw-bot: changes-requested > -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com