From: Thomas Monjalon <thomas@monjalon.net>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Cc: dev@dpdk.org, 'Ferruh Yigit' <ferruh.yigit@intel.com>,
'Pablo de Lara' <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] examples: remove unnecessary function calls
Date: Mon, 15 Jan 2018 12:11:43 +0100 [thread overview]
Message-ID: <7157985.Xa4WbqdXfG@xps> (raw)
In-Reply-To: <005201d372e4$a74cbb10$f5e63130$@lab.ntt.co.jp>
12/12/2017 02:00, Prashant Bhole:
>
> > -----Original Message-----
> > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> >
> > On 12/10/2017 11:31 PM, Prashant Bhole wrote:
> > > Removed rte_eth_dev_info_get() calls and declaration of struct
> > > rte_eth_dev_info where info is not used anymore
> > >
> > > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> >
> > At any point in the history were they used? If so, can you please add the commit
> > making them unnecessary with "Fixes" tag?
>
> Ferruh,
> Thanks for reviewing. Adding tag in reply. Let me know if v2 needed with the tag.
>
> Fixes: 81f7ecd934372fc9f592d1322f8eff86350fa4f5
Prashant, this is not the commit making them unnecessary.
next prev parent reply other threads:[~2018-01-15 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 1:00 [PATCH] examples: remove unnecessary function calls Prashant Bhole
2018-01-15 11:11 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 7:31 Prashant Bhole
2017-12-11 18:12 ` Ferruh Yigit
2018-01-15 11:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7157985.Xa4WbqdXfG@xps \
--to=thomas@monjalon.net \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.