From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 780A7E77188 for ; Wed, 8 Jan 2025 18:59:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVbGD-0000pp-NA; Wed, 08 Jan 2025 13:58:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVbG8-0000pK-24; Wed, 08 Jan 2025 13:58:28 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVbG4-00015m-Hu; Wed, 08 Jan 2025 13:58:27 -0500 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 508CeaBt026789; Wed, 8 Jan 2025 18:58:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=BsBnkv KmvWmRyk0yDTgj2iAGmQgFyV4u6KekuTpr8v8=; b=HSe4Fjh/AqCrkhuzt10iXT GlY2hBZ9Y31WS8AzmYV5TbWdHAsvkMxI499uxQmHnwMofgAcNa9iaiTqQ9XTJ0bh g5p2BzIyj8pHtRuLp6W7pH2K28zT1fU8R7RZVxBPBrGmQbF/s2U5DkgD2LUNvPOq c6pLOpsFW9VNA0k0KaKQ9VsPNnYaw2aWKWuWHYpqjw6F2e5O3LYROQPiyLWEh55T 5CvfX1sGhG2iprp4qvd9crRPoQpk9G1UFC2WmA2NAuMP8uh8wuvK/eFRS2cf0a/q agGbyEZbBxphlZJY1TKgJrI/TSLh9DAgu8YuOKJZl1tZPlxTAbLKaKjsVfh1L/oA == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 441e3b4k1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 18:58:18 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 508I6fnp026183; Wed, 8 Jan 2025 18:58:17 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yj128yny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jan 2025 18:58:17 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 508IwG5623790204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jan 2025 18:58:17 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C14E25805D; Wed, 8 Jan 2025 18:58:16 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 777C758043; Wed, 8 Jan 2025 18:58:15 +0000 (GMT) Received: from [9.61.241.32] (unknown [9.61.241.32]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 Jan 2025 18:58:15 +0000 (GMT) Message-ID: <7171c479-5cb4-4748-ba37-da4cf2fac35b@linux.ibm.com> Date: Wed, 8 Jan 2025 13:58:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, thuth@redhat.com, akrowiak@linux.ibm.com References: <20250107184354.91079-1-rreyes@linux.ibm.com> <20250107184354.91079-3-rreyes@linux.ibm.com> Content-Language: en-US From: Rorie Reyes In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hUS908DU7SuxXDzrBCTfmi8DcHj4KpB7 X-Proofpoint-GUID: hUS908DU7SuxXDzrBCTfmi8DcHj4KpB7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501080152 Received-SPF: pass client-ip=148.163.158.5; envelope-from=rreyes@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/8/25 2:34 AM, Cédric Le Goater wrote: > On 1/7/25 19:43, Rorie Reyes wrote: >> Register an event notifier handler to process AP configuration >> change events by queuing the event and generating a CRW to let >> the guest know its AP configuration has changed >> >> Signed-off-by: Rorie Reyes >> Reviewed-by: Anthony Krowiak >> Tested-by: Anthony Krowiak > > I don't recall a previous version of these changes where these > trailers were added. Was this part of an internal review ? > It is best to restart the process when the patches become public. > > Thanks, > > C. Hey Cédric, Yes these patches went through an internal review and Anthony Krowiak is the primary maintainer for VFIO-AP. This is my first upstream review so apologize for the confusion. Thanks, Rorie