From: Thomas Monjalon <thomas@monjalon.net>
To: Yicai Lu <luyicai@huawei.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
zhoujingbin@huawei.com, chenchanghu@huawei.com,
jerry.lilijun@huawei.com, haifeng.lin@huawei.com,
guohongzhi1@huawei.com, wangyunjian@huawei.com
Subject: Re: [dpdk-dev] [PATCH] ip_frag: recalculate data length of fragment
Date: Sun, 22 Nov 2020 12:22:22 +0100 [thread overview]
Message-ID: <7177305.MHKvZRkaxW@thomas> (raw)
In-Reply-To: <1605706193-17192-1-git-send-email-luyicai@huawei.com>
18/11/2020 14:29, Yicai Lu:
> In some situations, we would get several ip fragments， which total
> data length is less than minimum frame(64) and padding with zeros.
> Examples: Second Fragment is "a0a1 a2a3 a4a5 a6a7 0000 0000 ..."
> and Third Fragment is "a8a9 aaab acad aeaf b0b1 b2b3 ...".
> And then, we would reassemble Second and Third Fragment like this
> "a0a1 a2a3 a4a5 a6a7 0000 0000 ... a8a9 aaab acad aeaf b0b1 ...",
> which is not correct! So, we need recalculate the data length
> of fragment to remove invalid padings(zero)!
>
> Signed-off-by: Yicai Lu <luyicai@huawei.com>
Please add a line "Fixes" to identify the root cause,
it will help to know where to backport.
next prev parent reply other threads:[~2020-11-22 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:29 [dpdk-dev] [PATCH] ip_frag: recalculate data length of fragment Yicai Lu
2020-11-22 11:22 ` Thomas Monjalon [this message]
2020-11-23 2:27 ` [dpdk-dev] [PATCH v2] " Yicai Lu
2020-12-12 11:05 ` [dpdk-dev] [PATCH v5] ip_frag: remove padding " Yicai Lu
2020-12-14 14:44 ` Ananyev, Konstantin
2020-12-15 3:18 ` luyicai
2020-12-16 10:44 ` Ananyev, Konstantin
2020-12-16 10:54 ` luyicai
2020-12-16 13:36 ` [dpdk-dev] [PATCH v6] " Yicai Lu
2020-12-18 11:41 ` Ananyev, Konstantin
2021-01-15 10:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7177305.MHKvZRkaxW@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=dev@dpdk.org \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=konstantin.ananyev@intel.com \
--cc=luyicai@huawei.com \
--cc=wangyunjian@huawei.com \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.