From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tiwei Bie <btw@mail.ustc.edu.cn>
Cc: dev@dpdk.org, dprovan@bivio.net
Subject: Re: [PATCH v2] eal: don't reset getopt lib
Date: Wed, 04 Nov 2015 23:21:03 +0100 [thread overview]
Message-ID: <7181004.z2BJ7V5WGs@xps13> (raw)
In-Reply-To: <CALwxeUvgHjZu4EsbS8knmeCr_G5u50s9rXv0QMXrJD0qJP-3Rw@mail.gmail.com>
> > > Someone may need to call rte_eal_init() with a fake argc/argv array
> > > in the middle of using getopt() to parse its own unrelated argc/argv
> > > parameters. So getopt lib shouldn't be reset by rte_eal_init().
> > >
> > > Now eal will always save optind, optarg and optopt (and optreset on
> > > FreeBSD) at the beginning, initialize optind (and optreset on FreeBSD)
> > > to 1 before calling getopt_long(), then restore all values after.
> > >
> > > Suggested-by: Don Provan <dprovan@bivio.net>
> > > Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Signed-off-by: Tiwei Bie <btw@mail.ustc.edu.cn>
> > > Reviewed-by: Don Provan <dprovan@bivio.net>
> > > Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: David Marchand <david.marchand@6wind.com>
Applied, thanks
prev parent reply other threads:[~2015-11-04 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 11:46 [PATCH] eal: don't reset getopt lib Tiwei Bie
2015-10-15 16:22 ` Don Provan
2015-10-16 2:25 ` Tiwei Bie
2015-10-19 10:36 ` Bruce Richardson
2015-10-19 13:15 ` Tiwei Bie
2015-10-19 13:13 ` [PATCH v2] " Tiwei Bie
2015-10-19 13:16 ` Bruce Richardson
2015-10-21 5:33 ` David Marchand
2015-10-21 6:17 ` Tiwei Bie
2015-11-04 22:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7181004.z2BJ7V5WGs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=btw@mail.ustc.edu.cn \
--cc=dev@dpdk.org \
--cc=dprovan@bivio.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.