From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <dlemoal@kernel.org>, <linux-ide@vger.kernel.org>,
Niklas Cassel <cassel@kernel.org>, <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH] ata: libata: Remove ata_noop_qc_prep()
Date: Thu, 1 Aug 2024 21:10:51 +0300 [thread overview]
Message-ID: <7186ee2c-e1de-1b59-41b2-e2ca45e21b0e@omp.ru> (raw)
In-Reply-To: <20240801090151.1249985-1-dlemoal@kernel.org>
Hello!
Not sure why you keep leaving me out of CC on the patches that touch
the PATA drivers... :-/
On 8/1/24 12:01 PM, Damien Le Moal wrote:
> The function ata_noop_qc_prep(), as its name implies, does nothing and
> simply returns AC_ERR_OK. For drivers that do not need any special
> preparations of queued commands, we can avoid having to define struct
> ata_port qc_prep operation by simply testing if that operation is
> defined or not in ata_qc_issue(). Make this change and remove
> ata_noop_qc_prep().
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
prev parent reply other threads:[~2024-08-01 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:01 [PATCH] ata: libata: Remove ata_noop_qc_prep() Damien Le Moal
2024-08-01 9:11 ` John Garry
2024-08-01 9:27 ` Damien Le Moal
2024-08-01 18:10 ` Sergei Shtylyov
2024-08-01 18:10 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7186ee2c-e1de-1b59-41b2-e2ca45e21b0e@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.