From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956C0C433B4 for ; Thu, 15 Apr 2021 16:06:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A392961166 for ; Thu, 15 Apr 2021 16:06:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A392961166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B70641679; Thu, 15 Apr 2021 18:05:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B70641679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618502781; bh=fOti0JWVub3MDgJ5kLDJpIT/+/IarsGlfVqhfvXbb6U=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y9LsCFiGFJwn47poqbpzs2hRj642y5JtNxPIb5W6LRLiizeqy9sUCxBRwM6F99qNV JiTIj4Cm/WL9VK7v1rG1gQCiykO03vNMAzmirQSWE4hz7F6Bu+N/dWELUaJuRFvZOE fkykc9Nw0ViimTNllzbQ3IHULq8nw+1TJOYz5yBQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 210C3F8022D; Thu, 15 Apr 2021 18:04:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47E66F8025C; Thu, 15 Apr 2021 18:04:46 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 190B3F80128 for ; Thu, 15 Apr 2021 18:04:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 190B3F80128 IronPort-SDR: RmXkXw0KLDgNTdhT5uG+kUI2dLVGxS8qZQdQ9X4qp+64N6WQLzjVS8HPlLNG1Aw5lcLLGZQQ8s 8ij2kvfYrzDA== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="182005143" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="182005143" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 09:04:39 -0700 IronPort-SDR: m2Dl1SuLXmJiuU730Cb0MHegPf8sGJwNsfnIr58ngPf6RGESyw+O/ACrKA7uFpJNr79WIDA6rE TPkc5VgAXePw== X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="615684919" Received: from andrelei-mobl.amr.corp.intel.com (HELO [10.209.167.172]) ([10.209.167.172]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 09:04:38 -0700 Subject: Re: [PATCH] ASoC: SOF: use current DAI config during resume To: Mark Brown , Ranjani Sridharan References: <20210414165926.1875465-1-ranjani.sridharan@linux.intel.com> <20210415155309.GA48833@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <718ff501-df0d-93ff-5626-a190bf0bb05a@linux.intel.com> Date: Thu, 15 Apr 2021 11:04:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210415155309.GA48833@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: tiwai@suse.de, alsa-devel@alsa-project.org, Kai Vehmanen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 4/15/21 10:53 AM, Mark Brown wrote: > On Wed, Apr 14, 2021 at 09:59:26AM -0700, Ranjani Sridharan wrote: >> Recently, the sof_pcm_dai_link_fixup() function was >> updated to match SSP config with the PCM hw_params >> and set the current_config for the DAI widget. >> >> But the sof_restore_pipelines() function still chooses the >> default config for the DAI widget upon resuming. Fix this >> to use the last used config when setting up the DAI widget >> during resume. >> >> Fixes: a1e1f10a6ed6 ("ASoC: SOF: match SSP config with pcm hw params") > > I don't seem to have that commit. I think it should be: Fixes: c943a586f6e49 ("ASoC: SOF: match SSP config with pcm hw params") I can re-send if needed