All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] Armada100: Enable Ethernet support for GplugD
Date: Tue, 19 Jul 2011 09:34:51 +0530 (IST)	[thread overview]
Message-ID: <719500042.27330.1311048291986.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FB019D56@SC-VEXCH4.marvell.com>


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav at einfochips.com]
> > Sent: Monday, July 18, 2011 3:12 PM
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; Ajay Bhargav
> > Subject: [PATCH 4/4] Armada100: Enable Ethernet support for GplugD
> 
> BTW: This should be third patch, PHY support should be after FEC
> support.
> 

Can't we merge PHY and FEC together? 'coz without setting up PHY, FEC cannot
work properly. They are kind of connected.

> > 
> > This patch enables ethernet support for Marvell GplugD board.
> Network
> > related commands works.
> > 
> > Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> > ---
> >  arch/arm/include/asm/arch-armada100/armada100.h |   57
> > +++++++++++++++++++++++
> >  arch/arm/include/asm/arch-armada100/mfp.h       |   19 ++++++++
> >  board/Marvell/gplugd/gplugd.c                   |   38
> +++++++++++++++
> >  include/configs/gplugd.h                        |   19 +++++++-
> >  4 files changed, 131 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/include/asm/arch-armada100/armada100.h
> > b/arch/arm/include/asm/arch-armada100/armada100.h
> > index 3d567eb..849638d 100644
> > --- a/arch/arm/include/asm/arch-armada100/armada100.h
> > +++ b/arch/arm/include/asm/arch-armada100/armada100.h
> > @@ -41,6 +41,10 @@
> >  /* Functional Clock Selection Mask */
> >  #define APBC_FNCLKSEL(x)        (((x) & 0xf) << 4)
> > 
> > +/* Fast Ethernet Controller Clock register definition */
> > +#define FE_CLK_RST                0x1
> > +#define FE_CLK_ENA                0x8
> 
> Modifying armada100.h is not a part of board support patch, pls
> abstract and put it in separate patch
> 

Okay.. will do that.

Regards,
Ajay Bhargav

  reply	other threads:[~2011-07-19  4:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  9:41 [U-Boot] [PATCH 4/4] Armada100: Enable Ethernet support for GplugD Ajay Bhargav
2011-07-18 19:34 ` Prafulla Wadaskar
2011-07-19  4:04   ` Ajay Bhargav [this message]
2011-07-19 17:56     ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=719500042.27330.1311048291986.JavaMail.root@ahm.einfochips.com \
    --to=ajay.bhargav@einfochips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.