From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>, sched-ext@lists.linux.dev
Cc: void@manifault.com, arighi@nvidia.com, changwoo@igalia.com,
jserv@ccns.ncku.edu.tw, chia7712@gmail.com,
linux-kernel@vger.kernel.org,
Emil Tsalapatis <emil@etsalapatis.com>
Subject: Re: [PATCH v4 0/2] sched_ext: Update demo schedulers and selftests for deprecated APIs
Date: Fri, 13 Mar 2026 23:04:54 -1000 [thread overview]
Message-ID: <719a1f3866dec56f2c233cfc433bb5f3@kernel.org> (raw)
In-Reply-To: <20260314033708.26483-1-yphbchou0911@gmail.com>
Hello,
Patch 1 looks fine. For patch 2, ops.cpu_acquire/release() are already
removed from the tree, so this patch doesn't apply as-is.
Also, a couple minor things:
- select_cpu_vtime.bpf.c: There's an extra trailing blank line before
the closing brace in select_cpu_vtime_stopping().
- maximal.bpf.c: The sched_switch tracepoint's prev_state parameter is
typed as unsigned long but the TP_PROTO declares unsigned int.
Can you rebase and fix these up?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-03-14 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 3:36 [PATCH v4 0/2] sched_ext: Update demo schedulers and selftests for deprecated APIs Cheng-Yang Chou
2026-03-14 3:36 ` [PATCH v4 1/2] sched_ext: Update demo schedulers and selftests to use scx_bpf_task_set_dsq_vtime() Cheng-Yang Chou
2026-03-14 3:36 ` [PATCH v4 2/2] sched_ext: Update selftests to drop ops.cpu_acquire/release() Cheng-Yang Chou
2026-03-14 9:04 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-15 8:24 [PATCH v5 0/2] sched_ext: Update demo schedulers and selftests for deprecated APIs Cheng-Yang Chou
2026-03-15 8:24 ` [PATCH v4 " Cheng-Yang Chou
2026-03-15 8:34 ` Cheng-Yang Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719a1f3866dec56f2c233cfc433bb5f3@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=chia7712@gmail.com \
--cc=emil@etsalapatis.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.