From: Marek Vasut <marek.vasut@mailbox.org>
To: Mehmet Fide <mehmet.fide@gmail.com>,
Marek Vasut <marek.vasut+usb@mailbox.org>
Cc: Tom Rini <trini@konsulko.com>,
u-boot@lists.u-boot-project.org,
Mehmet Fide <mehmet.fide@screeningeagle.com>
Subject: Re: [PATCH 1/3] usb: ehci-vf: remove the code path for a build without DM_USB
Date: Wed, 19 Aug 2026 12:08:48 +0200 [thread overview]
Message-ID: <71b7897e-b11d-4f9c-b3c0-e7eb23e26bae@mailbox.org> (raw)
In-Reply-To: <20260819093705.4143509-2-mehmet.fide@gmail.com>
On 8/19/26 11:37 AM, Mehmet Fide wrote:
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
> USB_EHCI_HCD selects DM_USB, so the !CONFIG_IS_ENABLED(DM_USB) branch of
> this driver can never be selected. It also cannot compile: ehci_hcd_init()
> calls ehci_vf_common_init() with one argument while the function takes
> two, so the branch has been dead since the controller was added as a
> second parameter.
>
> Remove it, together with the board_usb_phy_mode() hook that no board
> implements and nothing else calls.
>
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
Could you please double-check that this is not used in SPL without DM_USB ?
next prev parent reply other threads:[~2026-08-20 3:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 9:37 [PATCH 0/3] usb: ehci-vf: take the register bases from the device tree Mehmet Fide
2026-08-19 9:37 ` [PATCH 1/3] usb: ehci-vf: remove the code path for a build without DM_USB Mehmet Fide
2026-08-19 10:08 ` Marek Vasut [this message]
2026-08-19 9:37 ` [PATCH 2/3] usb: ehci-vf: drop the empty bind hook Mehmet Fide
2026-08-19 10:10 ` Marek Vasut
2026-08-19 9:37 ` [PATCH 3/3] usb: ehci-vf: take the register bases from the device tree Mehmet Fide
2026-08-19 19:50 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b7897e-b11d-4f9c-b3c0-e7eb23e26bae@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=marek.vasut+usb@mailbox.org \
--cc=mehmet.fide@gmail.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.