All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Klara Modin <klarasmodin@gmail.com>,
	Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/uring_cmd: add io_uring_cmd_tw_t type alias
Date: Mon, 8 Sep 2025 08:20:42 -0600	[thread overview]
Message-ID: <71c05242-a522-4294-bfc5-d867bb154284@kernel.dk> (raw)
In-Reply-To: <3h5wdobeinxy7bbhvw3aztcns33cea3irxg4ckwvmds56ynyi4@45fy2e3uemz2>

On 9/7/25 6:33 AM, Klara Modin wrote:
>> @@ -104,11 +107,11 @@ static inline int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd,
>>  static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
>>  		u64 ret2, unsigned issue_flags)
>>  {
>>  }
>>  static inline void __io_uring_cmd_do_in_task(struct io_uring_cmd *ioucmd,
> 
>> -			    void (*task_work_cb)(struct io_uring_cmd *, unsigned),
>> +			    io_uring_tw_t task_work_cb,
> 
> There seems to have slipped in a typo for the !IO_URING stub here:
> s/io_uring_tw_t/io_uring_cmd_tw_t/

Indeed, that's my fault. I had to hand apply a few of those patches and
apparently butter fingered that hunk. I've queued up a fixup with a
Reported-by for you, thanks for catching that!

-- 
Jens Axboe

      reply	other threads:[~2025-09-08 14:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 16:06 [PATCH] io_uring/uring_cmd: add io_uring_cmd_tw_t type alias Caleb Sander Mateos
2025-09-02 17:46 ` Keith Busch
2025-09-03  1:21 ` Jens Axboe
2025-09-07 12:33 ` Klara Modin
2025-09-08 14:20   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c05242-a522-4294-bfc5-d867bb154284@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=klarasmodin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.