From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572A2C4363C for ; Wed, 7 Oct 2020 08:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F136E20870 for ; Wed, 7 Oct 2020 08:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fMGtC0/S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727886AbgJGIWq (ORCPT ); Wed, 7 Oct 2020 04:22:46 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:45210 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgJGIWq (ORCPT ); Wed, 7 Oct 2020 04:22:46 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0978McFf110394; Wed, 7 Oct 2020 03:22:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602058958; bh=fQFE7sGDqZdok5OvK6iGtl1lyFb8J/X+nm8IT+21uSg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=fMGtC0/S0jbk1EMLXNwUvXRaszFWa2NOfPXH4bHHiO7YvmLkBmgAMfMS5ukD5eb83 OI1eJNr+PWItT+zp6hF3TMekb07vTOXSwh2qE7IVcEHQQ1M92E+1pslWFrLLrw6bLS N7BJ9dIDQxyStn2qOkKUKPozD6hCYaVv9AQxFv34= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0978MbSr082643 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Oct 2020 03:22:37 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 7 Oct 2020 03:22:37 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 7 Oct 2020 03:22:37 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0978MYqc012043; Wed, 7 Oct 2020 03:22:35 -0500 Subject: Re: [PATCH 07/18] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API To: Vinod Koul CC: , , , , , , , , , , References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-8-peter.ujfalusi@ti.com> <20201007065305.GS2968@vkoul-mobl> From: Peter Ujfalusi Message-ID: <71d190e7-5654-e873-16b0-3b9bd6e8bf7a@ti.com> Date: Wed, 7 Oct 2020 11:22:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201007065305.GS2968@vkoul-mobl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 07/10/2020 9.53, Vinod Koul wrote: > On 30-09-20, 12:14, Peter Ujfalusi wrote: >> Glue layer users should use the device of the DMA for DMA mapping and >> allocations as it is the DMA which accesses to descriptors and buffers, >> not the clients >> >> Signed-off-by: Peter Ujfalusi >> --- >> drivers/dma/ti/k3-udma-glue.c | 14 ++++++++++++++ >> drivers/dma/ti/k3-udma-private.c | 6 ++++++ >> drivers/dma/ti/k3-udma.h | 1 + >> include/linux/dma/k3-udma-glue.h | 4 ++++ >> 4 files changed, 25 insertions(+) >> >> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c >> index a367584f0d7b..a53bc4707ae8 100644 >> --- a/drivers/dma/ti/k3-udma-glue.c >> +++ b/drivers/dma/ti/k3-udma-glue.c >> @@ -487,6 +487,13 @@ int k3_udma_glue_tx_get_irq(struct k3_udma_glue_tx_channel *tx_chn) >> } >> EXPORT_SYMBOL_GPL(k3_udma_glue_tx_get_irq); >> >> +struct device * >> + k3_udma_glue_tx_get_dma_device(struct k3_udma_glue_tx_channel *tx_chn) > > How about.. > > struct device * > k3_udma_glue_tx_get_dma_device(struct k3_udma_glue_tx_channel *tx_chn) OK. > >> +{ >> + return xudma_get_device(tx_chn->common.udmax); >> +} >> +EXPORT_SYMBOL_GPL(k3_udma_glue_tx_get_dma_device); > > Hmm why would you need to export this device.. Can you please outline > all the devices involved here... In upstream we have one user of the udma-glue layer: drivers/net/ethernet/ti/am65-cpsw-nuss.c It is allocating memory to be used with DMA (descriptor pool), it needs to use correct device for DMA API. The cpsw atm using it's own dev for allocation, which is wrong, but it worked fine as am654/j721e/j7200 is all coherent. > why not use dmaI_dev->dev or chan->dev? The glue layer does not use DMAengine API to request a channel as it require special resource setup compared to what is possible via generic API. We have kept the DMAengine and Glue layer as separate until I have time to extend the core to support the features we would need to remove the Glue layer. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F023C4727E for ; Wed, 7 Oct 2020 08:24:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 027EB20872 for ; Wed, 7 Oct 2020 08:24:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YIJJM5IY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fMGtC0/S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 027EB20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wZseQholfSzqnJSNbfHjj0mmzHzShaCpUhk4/OSljk4=; b=YIJJM5IYi6YSsHQRoQ5vZGKUH RWBBlair6L3lhVvym6iElgbVwV3iCo4U6xvefTpOWyC3WXDZIjw+z5Qp0c9pVMqgyEJX4ppoVsdCc 6+fRGDF4hLuUo9u7kXe57oHQ8nAJC2CutpfEIIBLSlM4ikG5xzUa2rsNnYwjfLl2sIAxd8LNDBcSp QGSccy+8UW6+k1kkHtEW7KWNega/VXiW6zbF+Er6M/1i5j+4xOteetGDUT4MdpSqkCj5QEu5RTDt2 Gg/VHKpYcRChUvVqVmQ0otfHhnFQS/6Ooi23hgX2srppm0wa8JNO/Znmo/OYq22vY4MyU/tQXMKBb hUkVeqErg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ4ik-00026S-U1; Wed, 07 Oct 2020 08:22:46 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ4ii-00025I-LP for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 08:22:45 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0978McFf110394; Wed, 7 Oct 2020 03:22:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602058958; bh=fQFE7sGDqZdok5OvK6iGtl1lyFb8J/X+nm8IT+21uSg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=fMGtC0/S0jbk1EMLXNwUvXRaszFWa2NOfPXH4bHHiO7YvmLkBmgAMfMS5ukD5eb83 OI1eJNr+PWItT+zp6hF3TMekb07vTOXSwh2qE7IVcEHQQ1M92E+1pslWFrLLrw6bLS N7BJ9dIDQxyStn2qOkKUKPozD6hCYaVv9AQxFv34= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0978MbSr082643 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Oct 2020 03:22:37 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 7 Oct 2020 03:22:37 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 7 Oct 2020 03:22:37 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0978MYqc012043; Wed, 7 Oct 2020 03:22:35 -0500 Subject: Re: [PATCH 07/18] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API To: Vinod Koul References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-8-peter.ujfalusi@ti.com> <20201007065305.GS2968@vkoul-mobl> From: Peter Ujfalusi Message-ID: <71d190e7-5654-e873-16b0-3b9bd6e8bf7a@ti.com> Date: Wed, 7 Oct 2020 11:22:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201007065305.GS2968@vkoul-mobl> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_042244_814872_AD3D527A X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAwNy8xMC8yMDIwIDkuNTMsIFZpbm9kIEtvdWwgd3JvdGU6Cj4gT24gMzAtMDktMjAsIDEy OjE0LCBQZXRlciBVamZhbHVzaSB3cm90ZToKPj4gR2x1ZSBsYXllciB1c2VycyBzaG91bGQgdXNl IHRoZSBkZXZpY2Ugb2YgdGhlIERNQSBmb3IgRE1BIG1hcHBpbmcgYW5kCj4+IGFsbG9jYXRpb25z IGFzIGl0IGlzIHRoZSBETUEgd2hpY2ggYWNjZXNzZXMgdG8gZGVzY3JpcHRvcnMgYW5kIGJ1ZmZl cnMsCj4+IG5vdCB0aGUgY2xpZW50cwo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBVamZhbHVz aSA8cGV0ZXIudWpmYWx1c2lAdGkuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZG1hL3RpL2szLXVk bWEtZ2x1ZS5jICAgIHwgMTQgKysrKysrKysrKysrKysKPj4gIGRyaXZlcnMvZG1hL3RpL2szLXVk bWEtcHJpdmF0ZS5jIHwgIDYgKysrKysrCj4+ICBkcml2ZXJzL2RtYS90aS9rMy11ZG1hLmggICAg ICAgICB8ICAxICsKPj4gIGluY2x1ZGUvbGludXgvZG1hL2szLXVkbWEtZ2x1ZS5oIHwgIDQgKysr Kwo+PiAgNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2RtYS90aS9rMy11ZG1hLWdsdWUuYyBiL2RyaXZlcnMvZG1hL3RpL2szLXVkbWEt Z2x1ZS5jCj4+IGluZGV4IGEzNjc1ODRmMGQ3Yi4uYTUzYmM0NzA3YWU4IDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2RtYS90aS9rMy11ZG1hLWdsdWUuYwo+PiArKysgYi9kcml2ZXJzL2RtYS90aS9r My11ZG1hLWdsdWUuYwo+PiBAQCAtNDg3LDYgKzQ4NywxMyBAQCBpbnQgazNfdWRtYV9nbHVlX3R4 X2dldF9pcnEoc3RydWN0IGszX3VkbWFfZ2x1ZV90eF9jaGFubmVsICp0eF9jaG4pCj4+ICB9Cj4+ ICBFWFBPUlRfU1lNQk9MX0dQTChrM191ZG1hX2dsdWVfdHhfZ2V0X2lycSk7Cj4+ICAKPj4gK3N0 cnVjdCBkZXZpY2UgKgo+PiArCWszX3VkbWFfZ2x1ZV90eF9nZXRfZG1hX2RldmljZShzdHJ1Y3Qg azNfdWRtYV9nbHVlX3R4X2NoYW5uZWwgKnR4X2NobikKPiAKPiBIb3cgYWJvdXQuLgo+IAo+IHN0 cnVjdCBkZXZpY2UgKgo+IGszX3VkbWFfZ2x1ZV90eF9nZXRfZG1hX2RldmljZShzdHJ1Y3QgazNf dWRtYV9nbHVlX3R4X2NoYW5uZWwgKnR4X2NobikKCk9LLgoKPiAKPj4gK3sKPj4gKwlyZXR1cm4g eHVkbWFfZ2V0X2RldmljZSh0eF9jaG4tPmNvbW1vbi51ZG1heCk7Cj4+ICt9Cj4+ICtFWFBPUlRf U1lNQk9MX0dQTChrM191ZG1hX2dsdWVfdHhfZ2V0X2RtYV9kZXZpY2UpOwo+IAo+IEhtbSB3aHkg d291bGQgeW91IG5lZWQgdG8gZXhwb3J0IHRoaXMgZGV2aWNlLi4gQ2FuIHlvdSBwbGVhc2Ugb3V0 bGluZQo+IGFsbCB0aGUgZGV2aWNlcyBpbnZvbHZlZCBoZXJlLi4uCgpJbiB1cHN0cmVhbSB3ZSBo YXZlIG9uZSB1c2VyIG9mIHRoZSB1ZG1hLWdsdWUgbGF5ZXI6CmRyaXZlcnMvbmV0L2V0aGVybmV0 L3RpL2FtNjUtY3Bzdy1udXNzLmMKCkl0IGlzIGFsbG9jYXRpbmcgbWVtb3J5IHRvIGJlIHVzZWQg d2l0aCBETUEgKGRlc2NyaXB0b3IgcG9vbCksIGl0IG5lZWRzCnRvIHVzZSBjb3JyZWN0IGRldmlj ZSBmb3IgRE1BIEFQSS4KVGhlIGNwc3cgYXRtIHVzaW5nIGl0J3Mgb3duIGRldiBmb3IgYWxsb2Nh dGlvbiwgd2hpY2ggaXMgd3JvbmcsIGJ1dCBpdAp3b3JrZWQgZmluZSBhcyBhbTY1NC9qNzIxZS9q NzIwMCBpcyBhbGwgY29oZXJlbnQuCgo+IHdoeSBub3QgdXNlIGRtYUlfZGV2LT5kZXYgb3IgY2hh bi0+ZGV2PwoKVGhlIGdsdWUgbGF5ZXIgZG9lcyBub3QgdXNlIERNQWVuZ2luZSBBUEkgdG8gcmVx dWVzdCBhIGNoYW5uZWwgYXMgaXQKcmVxdWlyZSBzcGVjaWFsIHJlc291cmNlIHNldHVwIGNvbXBh cmVkIHRvIHdoYXQgaXMgcG9zc2libGUgdmlhIGdlbmVyaWMKQVBJLiBXZSBoYXZlIGtlcHQgdGhl IERNQWVuZ2luZSBhbmQgR2x1ZSBsYXllciBhcyBzZXBhcmF0ZSB1bnRpbCBJIGhhdmUKdGltZSB0 byBleHRlbmQgdGhlIGNvcmUgdG8gc3VwcG9ydCB0aGUgZmVhdHVyZXMgd2Ugd291bGQgbmVlZCB0 byByZW1vdmUKdGhlIEdsdWUgbGF5ZXIuCgotIFDDqXRlcgoKVGV4YXMgSW5zdHJ1bWVudHMgRmlu bGFuZCBPeSwgUG9ya2thbGFua2F0dSAyMiwgMDAxODAgSGVsc2lua2kuClktdHVubnVzL0J1c2lu ZXNzIElEOiAwNjE1NTIxLTQuIEtvdGlwYWlra2EvRG9taWNpbGU6IEhlbHNpbmtpCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==