From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4] drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset Date: Fri, 18 May 2018 12:50:41 +0100 Message-ID: <71edce3d-66bb-e142-0b27-56ba7d17cd10@linux.intel.com> References: <20180518100933.2239-1-chris@chris-wilson.co.uk> <6e157f27-fcc6-ebe0-e549-c2f064f0c340@linux.intel.com> <152664185719.13126.12649173776048045383@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E2346ED36 for ; Fri, 18 May 2018 11:50:44 +0000 (UTC) In-Reply-To: <152664185719.13126.12649173776048045383@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA1LzIwMTggMTI6MTAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTE4IDEyOjA1OjE3KQo+Pgo+PiBPbiAxOC8wNS8yMDE4IDExOjA5 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJbnNpZGUgdGhlIGxpdmVfaGFuZ2NoZWNrIChyZXNl dCkgc2VsZnRlc3RzLCB3ZSBvY2Nhc2lvbmFsbHkgc2VlCj4+PiBmYWlsdXJlcyBsaWtlCj4+Pgo+ Pj4gPDc+WyAgMjM5LjA5NDg0MF0gaTkxNV9nZW1fc2V0X3dlZGdlZCByY3MwCj4+PiA8Nz5bICAy MzkuMDk0ODQzXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgY3VycmVudCBzZXFubyAxOWE5 OCwgbGFzdCAxOWE5YSwgaGFuZ2NoZWNrIDAgWzUxNTggbXNdCj4+PiA8Nz5bICAyMzkuMDk0ODQ2 XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUmVzZXQgY291bnQ6IDYyMzkgKGdsb2JhbCAx KQo+Pj4gPDc+WyAgMjM5LjA5NDg0OF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJlcXVl c3RzOgo+Pj4gPDc+WyAgMjM5LjA5NTA1Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAg ICAgICAgZmlyc3QgIDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUxNTltczogKG51bGwpCj4+ PiA8Nz5bICAyMzkuMDk1MDU2XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICBs YXN0ICAgMTlhOWEgW2U4MToxYV0gcHJpbz0xMzkgQCA1MTU5bXM6IGlndC9yY3MwWzU5NzddLzEK Pj4+IDw3PlsgIDIzOS4wOTUwNTldIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IGFjdGl2ZSAxOWE5OSBbZThjOjVmXSBwcmlvPTEwMjQgQCA1MTU5bXM6IChudWxsKQo+Pj4gPDc+ WyAgMjM5LjA5NTA2Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgW2hlYWQg MDIyMCwgcG9zdGZpeCAwMjgwLCB0YWlsIDAyYTgsIGJhdGNoIDB4ZmZmZmZmZmZfZmZmZmZmZmZd Cj4+PiA8Nz5bICAyMzkuMTAwMDUwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAg ICByaW5nLT5zdGFydDogIDB4MDAyODMwMDAKPj4+IDw3PlsgIDIzOS4xMDAwNTNdIGk5MTVfZ2Vt X3NldF93ZWRnZWQgICAgICAgICAgICAgICAgIHJpbmctPmhlYWQ6ICAgMHgwMDAwMDFmOAo+Pj4g PDc+WyAgMjM5LjEwMDA1NV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgcmlu Zy0+dGFpbDogICAweDAwMDAwMmE4Cj4+PiA8Nz5bICAyMzkuMTAwMDU3XSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgICAgICAgICByaW5nLT5lbWl0OiAgIDB4MDAwMDAyYTgKPj4+IDw3Plsg IDIzOS4xMDAwNTldIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAgIHJpbmctPnNw YWNlOiAgMHgwMDAwMGYxMAo+Pj4gPDc+WyAgMjM5LjEwMDA4NV0gaTkxNV9nZW1fc2V0X3dlZGdl ZCAgICAgICAgIFJJTkdfU1RBUlQ6IDB4MDAyODMwMDAKPj4+IDw3PlsgIDIzOS4xMDAwODhdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBSSU5HX0hFQUQ6ICAweDAwMDAwMjYwCj4+PiA8Nz5b ICAyMzkuMTAwMDkxXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUklOR19UQUlMOiAgMHgw MDAwMDJhOAo+Pj4gPDc+WyAgMjM5LjEwMDA5NF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAg IFJJTkdfQ1RMOiAgIDB4MDAwMDAwMDEKPj4+IDw3PlsgIDIzOS4xMDAwOTddIGk5MTVfZ2VtX3Nl dF93ZWRnZWQgICAgICAgICBSSU5HX01PREU6ICAweDAwMDAwMzAwIFtpZGxlXQo+Pj4gPDc+WyAg MjM5LjEwMDEwMF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJJTkdfSU1SOiBmZmZmZmVm ZQo+Pj4gPDc+WyAgMjM5LjEwMDEwNF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIEFDVEhE OiAgMHgwMDAwMDAwMF8wMDAwNjA5Ywo+Pj4gPDc+WyAgMjM5LjEwMDEwOF0gaTkxNV9nZW1fc2V0 X3dlZGdlZCAgICAgICAgIEJCQUREUjogMHgwMDAwMDAwMF8wMDAwNjA5ZAo+Pj4gPDc+WyAgMjM5 LjEwMDExMV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIERNQV9GQUREUjogMHgwMDAwMDAw MF8wMDI4MzI2MAo+Pj4gPDc+WyAgMjM5LjEwMDExNF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAg ICAgIElQRUlSOiAweDAwMDAwMDAwCj4+PiA8Nz5bICAyMzkuMTAwMTE3XSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgSVBFSFI6IDB4MDI4MDAwMDAKPj4+IDw3PlsgIDIzOS4xMDAxMjBdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBFeGVjbGlzdCBzdGF0dXM6IDB4MDAwNDQwNTIgMDAw MDAwMDIKPj4+IDw3PlsgIDIzOS4xMDAxMjRdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBF eGVjbGlzdCBDU0IgcmVhZCA1IFs1IGNhY2hlZF0sIHdyaXRlIDUgWzUgZnJvbSBod3NdLCBpbnRl cnJ1cHQgcG9zdGVkPyBubywgdGFza2xldCBxdWV1ZWQ/IG5vIChlbmFibGVkKQo+Pj4gPDc+WyAg MjM5LjEwMDEyOF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgRUxTUFswXSBj b3VudD0xLCByaW5nLT5zdGFydD0wMDI4MzAwMCwgcnE6IDE5YTk5IFtlOGM6NWZdIHByaW89MTAy NCBAIDUxNjRtczogKG51bGwpCj4+PiA8Nz5bICAyMzkuMTAwMTMyXSBpOTE1X2dlbV9zZXRfd2Vk Z2VkICAgICAgICAgICAgICAgICBFTFNQWzFdIGNvdW50PTEsIHJpbmctPnN0YXJ0PTAwMjU3MDAw LCBycTogMTlhOWEgW2U4MToxYV0gcHJpbz0xMzkgQCA1MTY0bXM6IGlndC9yY3MwWzU5NzddLzEK Pj4+IDw3PlsgIDIzOS4xMDAxMzVdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IEhXIGFjdGl2ZT8gMHg1Cj4+PiA8Nz5bICAyMzkuMTAwMjUwXSBpOTE1X2dlbV9zZXRfd2VkZ2Vk ICAgICAgICAgICAgICAgICBFIDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUxNjRtczogKG51 bGwpCj4+PiA8Nz5bICAyMzkuMTAwMzM4XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAg ICAgICBFIDE5YTlhIFtlODE6MWFdIHByaW89MTM5IEAgNTE2NG1zOiBpZ3QvcmNzMFs1OTc3XS8x Cj4+PiA8Nz5bICAyMzkuMTAwMzQwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAg ICBRdWV1ZSBwcmlvcml0eTogMTM5Cj4+PiA8Nz5bICAyMzkuMTAwMzQzXSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgICAgICAgICBRIDAgW2U5ODoxOV0gcHJpbz0xMzIgQCA1MTY0bXM6IGln dC9yY3MwWzU5NzddLzgKPj4+IDw3PlsgIDIzOS4xMDAzNDZdIGk5MTVfZ2VtX3NldF93ZWRnZWQg ICAgICAgICAgICAgICAgIFEgMCBbZTg0OjE5XSBwcmlvPTEyMSBAIDUxNjVtczogaWd0L3JjczBb NTk3N10vMgo+Pj4gPDc+WyAgMjM5LjEwMDM0OV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAg ICAgICAgICAgUSAwIFtlODc6MTldIHByaW89ODIgQCA1MTY1bXM6IGlndC9yY3MwWzU5NzddLzMK Pj4+IDw3PlsgIDIzOS4xMDAzNTJdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IFEgMCBbZTg0OjFhXSBwcmlvPTQ0IEAgNTE2NG1zOiBpZ3QvcmNzMFs1OTc3XS8yCj4+PiA8Nz5b ICAyMzkuMTAwMzU2XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICBRIDAgW2U4 YjoxOV0gcHJpbz0yMCBAIDUxNjVtczogaWd0L3JjczBbNTk3N10vNAo+Pj4gPDc+WyAgMjM5LjEw MDM2Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIGRydl9zZWxmdGVzdCBbNTg5NF0gd2Fp dGluZyBmb3IgMTlhOTkKPj4+Cj4+PiB3aGVyZSB0aGUgR1BVIHNhdyBhbiBhcmJpdHJhdGlvbiBw b2ludCBhbmQgaWRsZXM7IEFORCBIQVMgTk9UIEJFRU4gUkVTRVQhCj4+PiBUaGUgUklOR19NT0RF IGluZGljYXRlcyB0aGF0IGlzIGlkbGUgYW5kIGhhcyB0aGUgU1RPUF9SSU5HIGJpdCBzZXQsIHNv Cj4+PiB0cnkgY2xlYXJpbmcgaXQuCj4+Pgo+Pj4gdjI6IE9ubHkgY2xlYXIgdGhlIGJpdCBvbiBy ZXN0YXJ0aW5nIHRoZSByaW5nLCBhcyB3ZSB3YW50IHRvIGJlIHN1cmUgdGhlCj4+PiBTVE9QX1JJ TkcgYml0IGlzIGtlcHQgaWYgcmVzZXQgZmFpbHMgb24gd2VkZ2luZy4KPj4+IHYzOiBTcG90IHdo ZW4gdGhlIHJpbmcgc3RhdGUgZG9lc24ndCBtYWtlIHNlbnNlIHdoZW4gcmUtaW5pdGlhbGlzaW5n IHRoZQo+Pj4gZW5naW5lIGFuZCBkdW1wIGl0IHRvIHRoZSBsb2dzIHNvIHRoYXQgd2UgZG9uJ3Qg aGF2ZSB0byB3YWl0IGZvciBhbgo+Pj4gZXJyb3IgbGF0ZXIgYW5kIHRyeSB0byBndWVzcyB3aGF0 IGhhcHBlbmVkIGVhcmxpZXIuCj4+PiB2NDogUHJlcGFyZSB0byBwcmludCBhbGwgdGhlIHVuZXhw ZWN0ZWQgc3RhdGUsIG5vdCBqdXN0IHRoZSBmaXJzdC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENjOiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyB8IDIyICsrKysrKysrKysrKysrKysrKysrKysK Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspCj4+Pgo+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMKPj4+IGluZGV4IDM3NDRmNTc1MDYyNC4uYmE4NDExYmE0YWJmIDEwMDY0 NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+PiBAQCAtMTc4MSw2ICsxNzgxLDkgQEAg c3RhdGljIHZvaWQgZW5hYmxlX2V4ZWNsaXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4+PiAgICAgICAgICAgICAgICBJOTE1X1dSSVRFKFJJTkdfTU9ERV9HRU43KGVuZ2luZSks Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgIF9NQVNLRURfQklUX0VOQUJMRShHRlhfUlVO X0xJU1RfRU5BQkxFKSk7Cj4+PiAgICAKPj4+ICsgICAgIEk5MTVfV1JJVEUoUklOR19NSV9NT0RF KGVuZ2luZS0+bW1pb19iYXNlKSwKPj4+ICsgICAgICAgICAgICAgICAgX01BU0tFRF9CSVRfRElT QUJMRShTVE9QX1JJTkcpKTsKPj4KPj4gV29ycmllcyBtZSBhIGJpdCB0byBjbGVhciBpdCB1bmNv bmRpdGlvbmFsbHkgc2luY2UgZG9jdW1lbnRhdGlvbiBzYXlzCj4+IG5vdGhpbmcgKHRoYXQgSSBj YW4gZmluZCkgYWJvdXQgdGhpcyBzY2VuYXJpby4KPj4KPj4+ICsKPj4+ICAgICAgICBJOTE1X1dS SVRFKFJJTkdfSFdTX1BHQShlbmdpbmUtPm1taW9fYmFzZSksCj4+PiAgICAgICAgICAgICAgICAg ICBlbmdpbmUtPnN0YXR1c19wYWdlLmdndHRfb2Zmc2V0KTsKPj4+ICAgICAgICBQT1NUSU5HX1JF QUQoUklOR19IV1NfUEdBKGVuZ2luZS0+bW1pb19iYXNlKSk7Cj4+PiBAQCAtMTc4OSw2ICsxNzky LDE5IEBAIHN0YXRpYyB2b2lkIGVuYWJsZV9leGVjbGlzdHMoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+Pj4gICAgICAgIGVuZ2luZS0+ZXhlY2xpc3RzLmNzYl9oZWFkID0gLTE7Cj4+ PiAgICB9Cj4+PiAgICAKPj4+ICtzdGF0aWMgYm9vbCB1bmV4cGVjdGVkX3N0YXJ0aW5nX3N0YXRl KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICt7Cj4+PiArICAgICBzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4+PiArICAgICBib29s IHVuZXhwZWN0ZWQgPSBmYWxzZTsKPj4+ICsKPj4+ICsgICAgIGlmIChJOTE1X1JFQUQoUklOR19N SV9NT0RFKGVuZ2luZS0+bW1pb19iYXNlKSkgJiBTVE9QX1JJTkcpIHsKPj4+ICsgICAgICAgICAg ICAgRFJNX0RFQlVHX0RSSVZFUigiU1RPUF9SSU5HIHN0aWxsIHNldCBpbiBSSU5HX01JX01PREVc biIpOwo+Pgo+PiBBbHNvIHdvcnJpZXMgbWUgdG8gYnVyeSB0aGlzIGFzIGEgZGVidWcgbWVzc2Fn ZSB1bmxlc3Mgd2UgY2FuIGZpbmQgaW4KPj4gZG9jdW1lbnRhdGlvbiB0aGF0IHRoaXMgaXMga25v d24gdG8gaGFwcGVuIG9jY2FzaW9uYWxseS4KPj4KPj4gSWYgd2UgaGFkIHRoZSBjaGVjayBhbmQg bG9nZ2luZyBpbW1lZGlhdGVseSBhZnRlciByZXNldCwgd2l0aCBhIG1vcmUKPj4gdmlzaWJsZSBs b2csIHdlIGNvdWxkIGJ1aWxkIGEgbGFyZ2VyIGRhdGEgc2V0IG9mIHJlcG9ydGVkIGZhaWx1cmVz IGFuZAo+PiB0aGVuIGdvIGJhY2sgdG8gaHcgcGVvcGxlIGFuZCBhc2sgdGhlbSBhYm91dCBpdC4K PiAKPiBUaGUgcHJvYmxlbSB3aXRoIHRoZSByZXNldCBzaWRlIGlzIHRyeWluZyB0byBhdm9pZCBt aXhpbmcgaW4gdGhlIGNhc2UKPiB3aGVyZSB3ZSBhcmUgZmFraW5nIGl0IGFuZCBleHBlY3QgaXQg dG8gc3RpbGwgYmUgc2V0LiBPbiB0aGUgcmluZ2J1ZmZlcgo+IHBhdGgsIHdlIGhhbmRsZSBTVE9Q X1JJTkcgYXMgYmVpbmcgcGFydCBvZiB0aGUgaW5pdCBzZXF1ZW5jZS4gVGhlIGxvZwo+IGFscmVh ZHkgc2F5cyB3ZSBkaWQgYSByZXNldCBhbmQgU1RPUF9SSU5HIGlzIHNldCAoc2luY2Ugd2UgaGF2 ZSB0cmFjaW5nCj4gdGhyb3VnaCB0aGUgcmVzZXQpLCBJIGp1c3QgbmVlZCB0byBmaW5kIHRoZSBy aWdodCBzcG90IHRvIGhhbmRsZSBpdC4KClRoZSAiZGlzdGFuY2UiIGluIGNvZGUgcGF0aHMgYmV0 d2VlbiByZXNldCBhbmQgaW5pdF9odyBpcyBwcm9iYWJseSB0aGUgCnNtYWxsZXN0IG9mIG15IGNv bmNlcm5zLiBJZiB3ZSBjb3VsZCBtYWtlIHRoaXMgbWVzc2FnZSBub3QgZGVidWcgb25seSwgCmFu ZCBjbGVhciBTVE9QX1JJTkcgb25seSBjb25kaXRpb25hbGx5IEkgdGhpbmsgSSB3b3VsZCBiZSBo YXBweSB3aXRoIApnaXZpbmcgdGhpcyBhIGdvIGFuZCBzZWUgaWYgaXQgY29sbGVjdHMgYW55IGRh dGEuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=