All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Richard <thomas.richard@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Werner Gartner <Werner.Gartner@congatec.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup
Date: Fri, 11 Sep 2026 19:33:24 +0200	[thread overview]
Message-ID: <72007ea8-b033-421f-a78b-ecd4accb6f07@bootlin.com> (raw)
In-Reply-To: <af677e7d-a605-4e63-8fad-6bf491dade07@roeck-us.net>

On 9/11/26 3:57 PM, Guenter Roeck wrote:
> On 9/11/26 00:23, Thomas Richard wrote:
>> On 9/11/26 2:58 AM, Guenter Roeck wrote:
>>> On Thu, Sep 10, 2026 at 03:28:21PM +0200, Thomas Richard (congatec
>>> GmbH) wrote:
>>>> Current sensors on the Congatec Board Controller don't use
>>>> consecutive IDs,
>>>> unlike other sensor types (voltage, temperature, fan). The driver
>>>> assumed
>>>> consecutive IDs and performed a simple lookup, which caused an unknown
>>>> sensor warning. Define current sensor IDs explicitly.
>>>>
>>>> Changes the warning on conga-SA7 (type and channel are correct now).
>>>> Before:
>>>>    Board Controller returned an unknown sensor (type=2, channel=17),
>>>> ignore it
>>>> After:
>>>>    Board Controller returned an unknown sensor (bc_type=1,
>>>> bc_id=11), ignore it
>>>>
>>>> Cc: stable@kernel.org
>>>> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller
>>>> monitoring driver")
>>>> Signed-off-by: Thomas Richard (congatec GmbH)
>>>> <thomas.richard@bootlin.com>
>>>
>>> Applied.
>>>
>>
>> You pointed me that Sashiko reported a missing cgbc_hwmon_info array but
>> you applied the patch. Should I send a v2 or an other patch to fix it?
>>
> Sorry, too much going on. Either way is fine.
No problem, I sent a v2.

Best Regards,
Thomas

  reply	other threads:[~2026-09-11 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 13:28 [PATCH 0/2] Congatec Board Controller: Fix current sensor lookup and add new sensors Thomas Richard (congatec GmbH)
2026-09-10 13:28 ` [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup Thomas Richard (congatec GmbH)
2026-09-10 13:45   ` sashiko-bot
2026-09-11  0:58   ` Guenter Roeck
2026-09-11  7:23     ` Thomas Richard
2026-09-11 13:57       ` Guenter Roeck
2026-09-11 17:33         ` Thomas Richard [this message]
2026-09-10 13:28 ` [PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors Thomas Richard (congatec GmbH)
2026-09-10 13:45   ` sashiko-bot
2026-09-10 14:56     ` Guenter Roeck
2026-09-11  0:59   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72007ea8-b033-421f-a78b-ecd4accb6f07@bootlin.com \
    --to=thomas.richard@bootlin.com \
    --cc=Werner.Gartner@congatec.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.