All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Modutils 2.5 change, start running this command now
Date: Fri, 12 Oct 2001 21:37:15 +1000	[thread overview]
Message-ID: <7202.1002886635@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Fri, 12 Oct 2001 06:04:20 -0400." <20011012060419.A1649@redhat.com>

On Fri, 12 Oct 2001 06:04:20 -0400, 
Benjamin LaHaise <bcrl@redhat.com> wrote:
>On Thu, Oct 11, 2001 at 09:45:58PM +1000, Keith Owens wrote:
>> In current modutils, a module that does not export symbols and does not
>> say EXPORT_NO_SYMBOLS will default to exporting all symbols.  This is a
>> hangover from kernel 2.0 and will be removed when modutils 2.5 appears,
>> shortly after the kernel 2.5 branch is created.
>> 
>> Starting with modutils 2.5, modules must explicitly say what their
>> intention is for symbols.  That will break a lot of existing modules.
>
>Isn't EXPORT_NO_SYMBOLS the default case for 99.44% of modules?  It seems 
>to me that the lameness incurred in adding an EXPORT_NO_SYMBOLS line to 
>each and every driver that one writes is a pointless additional hoop to 
>jump through.  I'd rather break the modules that are relying on behaviour 
>that was deprecated several *years* ago than go through another make-work 
>project.

I was going to do it that way.  The problem is that it gives no
indication if the module has been checked or not.  Adding
EXPORT_NO_SYMBOLS says that somebody has reviewed the module and
decided that exporting no symbols is the correct behaviour.  It is the
difference between no maintainer and a maintained module.


  reply	other threads:[~2001-10-12 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-11 11:45 Modutils 2.5 change, start running this command now Keith Owens
2001-10-12  6:34 ` Ingo Oeser
2001-10-12 10:04 ` Benjamin LaHaise
2001-10-12 11:37   ` Keith Owens [this message]
2001-10-12 12:14     ` David Woodhouse
2001-10-12 14:40       ` Keith Owens
2001-10-12 15:01       ` Tom Rini
2001-10-15 16:05 ` [PATCH] meye camera driver EXPORT_NO_SYMBOLS Stelian Pop
  -- strict thread matches above, loose matches on Subject: below --
2001-10-03  4:36 Modutils 2.5 change, start running this command now Keith Owens
2001-10-03  4:48 ` Robert Love
2001-10-03  8:17 ` Russell King
2001-10-03 11:59   ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7202.1002886635@ocs3.intra.ocs.com.au \
    --to=kaos@ocs.com.au \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.