All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xuyang Dong" <dongxuyang@eswincomputing.com>
To: "Julian Braha" <julianbraha@gmail.com>,
	linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, p.zabel@pengutronix.de,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
	pinkesh.vaghela@einfochips.com, luyulin@eswincomputing.com
Subject: Re: Re: [PATCH v8 2/2] hwmon: Add Eswin EIC7700 PVT sensor driver
Date: Mon, 29 Jun 2026 11:18:36 +0800 (GMT+08:00)	[thread overview]
Message-ID: <720f0b80.7c8d.19f1162d004.Coremail.dongxuyang@eswincomputing.com> (raw)
In-Reply-To: <66945d22-17e4-4856-9704-8256650c4b25@gmail.com>

Hi Julian,

> 
> On 6/25/26 07:12, hehuan1@eswincomputing.com wrote:
> > +config SENSORS_EIC7700_PVT
> > +	tristate "Eswin EIC7700 Voltage, Temperature sensor driver"
> > +	depends on ARCH_ESWIN || COMPILE_TEST
> > +	depends on HWMON
> 
> You already put SENSORS_EIC7700_PVT inside the 'if HWMON .. endif', so
> you don't need the 'depends on HWMON'. It creates a duplicate
> dependency.
> 

Will drop the 'depends on HWMON' in the next version.

Best regards,
Xuyang Dong


      reply	other threads:[~2026-06-29  3:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  6:10 [PATCH v8 0/2] Add driver support for ESWIN EIC7700 PVT controller hehuan1
2026-06-25  6:11 ` [PATCH v8 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor hehuan1
2026-06-25  6:17   ` sashiko-bot
2026-06-25 16:34   ` Conor Dooley
2026-06-25  6:12 ` [PATCH v8 2/2] hwmon: Add Eswin EIC7700 PVT sensor driver hehuan1
2026-06-25  6:22   ` sashiko-bot
2026-06-29 20:41     ` Guenter Roeck
2026-06-25 11:16   ` Julian Braha
2026-06-29  3:18     ` Xuyang Dong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720f0b80.7c8d.19f1162d004.Coremail.dongxuyang@eswincomputing.com \
    --to=dongxuyang@eswincomputing.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=julianbraha@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linmin@eswincomputing.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luyulin@eswincomputing.com \
    --cc=ningyu@eswincomputing.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pinkesh.vaghela@einfochips.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.