Re: [PATCH v2 2/4] ASoC: SDCA: Add basic system suspend support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

> +static int class_suspend(struct device *dev)
> +{
> +	struct sdca_class_drv *drv = dev_get_drvdata(dev);
> +	int ret;
> +
> +	disable_irq(drv->sdw->irq);
> +
> +	ret = pm_runtime_force_suspend(dev);
> +	if (ret) {
> +		dev_err(dev, "Failed to force suspend: %d\n", ret);

suggestion: since this is going to be fairly generic code used by multiple devices, it'd be useful to add a device identifier or string to the error log, no?

This can be done later in a follow-up patch if agreed.


> +	if (drv->suspended) {
> +		sdca_irq_enable_early(drv->function, drv->core->irq_info);
> +		sdca_irq_enable(drv->function, drv->core->irq_info);

maybe add a comment on why the two calls are done sequentially. You did mention it somewhere, it'd be good to capture the design.

looks good otherwise.