From: Thomas Monjalon <thomas@monjalon.net>
To: Jie Zhou <jizh@linux.microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>,
Jie Zhou <jizh@microsoft.com>,
Narcisa Vasile <navasile@linux.microsoft.com>,
dmitrym@microsoft.com, pallavi.kadam@intel.com,
bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK
Date: Tue, 16 Mar 2021 12:09:48 +0100 [thread overview]
Message-ID: <7214899.8EVLAoSQA2@thomas> (raw)
In-Reply-To: <BY5PR21MB14265622E1FAC21E8D947893D0939@BY5PR21MB1426.namprd21.prod.outlook.com>
08/03/2021 19:32, Jie Zhou:
> Add Dmitry.
There are more maintainers to Cc.
I recommend using Linux for sending the patches,
so you can use the script devtools/get-maintainer.sh
with the option --cc-cmd.
> From: Jie Zhou <jizh@microsoft.com>
>
> Meson with Windows clang generates incorrect linker flag "--subsystem,console" instead of "/subsystem:console" which will fail the DPDK build. This is discovered at porting testpmd.
>
> Meson 0.57.0 has the fix and should be used for DPDK Windows build.
> Update the DPDK WindowsGSG DPDK Build document for the proper meson version. Will then sync with ci@dpdk.org to update meson in CI pipeline.
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
Why signing with a different email address than the "From"?
[...]
> https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmesonbuild.com%2FGetting-meson.html%23installing-meson-and-ninja-with-the-msi-installer%2522&data=04%7C01%7Cjizh%40microsoft.com%7C124559f34a4245cef68808d8d91d1508%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637498066227214579%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oXVIHUzLnN0KkaRED1skiCq3W1LQRJS8H0NAHCCvu6A%3D&reserved=0
That's interesting how your mail server can break a patch :)
> -Recommended version is either Meson 0.47.1 (baseline) or the latest release.
> +Recommended version is either Meson 0.57.0 (baseline) or the latest release.
I am OK with the change. What others think?
next prev parent reply other threads:[~2021-03-16 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 23:36 [dpdk-dev] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK Jie Zhou
2021-03-08 18:32 ` [dpdk-dev] [EXTERNAL] " Jie Zhou
2021-03-16 11:09 ` Thomas Monjalon [this message]
2021-03-17 0:00 ` Dmitry Kozlyuk
2021-04-16 17:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7214899.8EVLAoSQA2@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=jizh@linux.microsoft.com \
--cc=jizh@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.