From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCw2r-0006Vi-8H for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:38:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCw2m-0000SJ-85 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:38:48 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:36888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCw2m-0000Ru-05 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 17:38:44 -0400 Date: Tue, 14 Jun 2016 17:38:42 -0400 (EDT) From: Paolo Bonzini Message-ID: <722462862.22421584.1465940322027.JavaMail.zimbra@redhat.com> In-Reply-To: <20160614213103.GB18662@thinpad.lan.raisama.net> References: <1465937948-548-1-git-send-email-ehabkost@redhat.com> <1465937948-548-11-git-send-email-ehabkost@redhat.com> <1990888058.22417362.1465939000140.JavaMail.zimbra@redhat.com> <20160614213103.GB18662@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 10/10] target-i386: Print obsolete warnings if +-features are used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Andreas =?utf-8?Q?F=C3=A4rber?= , qemu-devel@nongnu.org, Richard Henderson , Igor Mammedov ----- Original Message ----- > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: "Peter Maydell" , "Andreas F=C3=A4rber" , qemu-devel@nongnu.org, "Richard > Henderson" , "Igor Mammedov" > Sent: Tuesday, June 14, 2016 11:31:03 PM > Subject: Re: [PULL 10/10] target-i386: Print obsolete warnings if +-featu= res are used >=20 > On Tue, Jun 14, 2016 at 05:16:40PM -0400, Paolo Bonzini wrote: > > ----- Original Message ----- > > > From: "Eduardo Habkost" > > > To: "Peter Maydell" > > > Cc: "Andreas F=C3=A4rber" , qemu-devel@nongnu.org, = "Richard > > > Henderson" , "Paolo > > > Bonzini" , "Igor Mammedov" > > > Sent: Tuesday, June 14, 2016 10:59:08 PM > > > Subject: [PULL 10/10] target-i386: Print obsolete warnings if +-featu= res > > > are used > > >=20 > > > From: Igor Mammedov > > >=20 > > > Signed-off-by: Igor Mammedov > > > [ehabkost: Changed to use error_report()] > > > Signed-off-by: Eduardo Habkost > > > --- > > > target-i386/cpu.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > >=20 > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > > index 3665fec..baa3783 100644 > > > --- a/target-i386/cpu.c > > > +++ b/target-i386/cpu.c > > > @@ -1980,9 +1980,15 @@ static void x86_cpu_parse_featurestr(CPUState = *cs, > > > char *features, > > > /* Compatibility syntax: */ > > > if (featurestr[0] =3D=3D '+') { > > > add_flagname_to_bitmaps(featurestr + 1, plus_features, > > > &local_err); > > > + error_report( > > > + "'+%s' is obsolete and will be removed in future, us= e > > > '%s=3Don'", > > > + featurestr + 1, featurestr + 1); > > > continue; > > > } else if (featurestr[0] =3D=3D '-') { > > > add_flagname_to_bitmaps(featurestr + 1, minus_features, > > > &local_err); > > > + error_report( > > > + "'-%s' is obsolete and will be removed in future, us= e > > > '%s=3Doff'", > > > + featurestr + 1, featurestr + 1); > > > continue; > > > } > >=20 > > I still disagree with this change. >=20 > I've just removed the patch from the x86-pull-request tag, while > we sort this out. >=20 > Do you suggest supporting the "[+-]feature" syntax forever? I suggest supporting it, but removing the awful interaction with "feature= =3Don/off" as soon as possible. This shouldn't block this pull request, of course. I just believe it's not practical to remove the feature. For example kvm-unit-tests can be used with new kernel and old QEMU, so I don't think it will move away from [+-]feature very soon. Regarding libvirt, is "feature=3Don/off" introspectable? That would also b= e a problem for libvirt to support both old and new QEMU. Paolo