From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2BcL-0002ZA-GB
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:26:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2BcI-0002Xo-Sm
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:26:44 -0500
Received: from [199.232.76.173] (port=33023 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2BcI-0002Xg-Jc
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:26:42 -0500
Received: from smtp4-g19.free.fr ([212.27.42.30]:57157)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <revol@free.fr>) id 1L2BcI-0000km-E2
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 16:26:42 -0500
Received: from smtp4-g19.free.fr (localhost.localdomain [127.0.0.1])
	by smtp4-g19.free.fr (Postfix) with ESMTP id C63163EA447
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 22:26:39 +0100 (CET)
Received: from laptop (vaf26-2-82-244-111-82.fbx.proxad.net [82.244.111.82])
	by smtp4-g19.free.fr (Postfix) with ESMTP id EE23A3EA1E2
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 22:26:24 +0100 (CET)
In-Reply-To: <9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
From: "=?windows-1252?q?Fran=E7ois?= Revol" <revol@free.fr>
Date: Mon, 17 Nov 2008 22:30:52 +0100 CET
Message-Id: <7235393795-BeMail@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> -    /* TODO: Implement compressed images.  */
> -    if (hdr->ih=5Fcomp !=3D IH=5FCOMP=5FNONE) {
> -        fprintf(stderr, "Unable to load compressed u-boot images\
> n");
> +    /* TODO bzip2 support */
> +    if (hdr->ih=5Fcomp =3D=3D IH=5FCOMP=5FBZIP2) {
> +        fprintf(stderr, "Unable to load bzip2 compressed u-boot 
> images\n");

Shouldn't it still be testing for !=3DNONE && !=3DGZIP =3F
In case the header is incorrect or new compressions are added =3F

Fran=E7ois.