All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin KaFai Lau <martin.lau@linux.dev>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: razor@blackwall.org, kuba@kernel.org, jrife@google.com,
	tangchen.1@bytedance.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 5/5] selftests/bpf: Extend netkit tests to validate skb meta data
Date: Mon, 7 Oct 2024 18:40:26 -0700	[thread overview]
Message-ID: <72385fe9-e34d-4642-a62c-61083395c722@linux.dev> (raw)
In-Reply-To: <20241004101335.117711-5-daniel@iogearbox.net>

On 10/4/24 3:13 AM, Daniel Borkmann wrote:
> +void serial_test_tc_netkit_scrub_type(int scrub)

nit. This can be static. Others lgtm. I can adjust before landing.

  parent reply	other threads:[~2024-10-08  1:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 10:13 [PATCH bpf-next v2 1/5] netkit: Add option for scrubbing skb meta data Daniel Borkmann
2024-10-04 10:13 ` [PATCH bpf-next v2 2/5] netkit: Simplify netkit mode over to use NLA_POLICY_MAX Daniel Borkmann
2024-10-05 13:38   ` Nikolay Aleksandrov
2024-10-04 10:13 ` [PATCH bpf-next v2 3/5] netkit: Add add netkit scrub support to rt_link.yaml Daniel Borkmann
2024-10-05 13:38   ` Nikolay Aleksandrov
2024-10-04 10:13 ` [PATCH bpf-next v2 4/5] tools: Sync if_link.h uapi tooling header Daniel Borkmann
2024-10-05 13:39   ` Nikolay Aleksandrov
2024-10-05 16:02   ` Stephen Hemminger
2024-10-08  1:36     ` Martin KaFai Lau
2024-10-04 10:13 ` [PATCH bpf-next v2 5/5] selftests/bpf: Extend netkit tests to validate skb meta data Daniel Borkmann
2024-10-05 13:39   ` Nikolay Aleksandrov
2024-10-08  1:40   ` Martin KaFai Lau [this message]
2024-10-04 23:15 ` [PATCH bpf-next v2 1/5] netkit: Add option for scrubbing " Jakub Kicinski
2024-10-05 13:38 ` Nikolay Aleksandrov
2024-10-08  2:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72385fe9-e34d-4642-a62c-61083395c722@linux.dev \
    --to=martin.lau@linux.dev \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jrife@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=razor@blackwall.org \
    --cc=tangchen.1@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.