From: Luka Gejak <luka.gejak@linux.dev>
To: Ping-Ke Shih <pkshih@realtek.com>,
Kalpesh Solanki <skalpesh942@gmail.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 0/3] wifi: rtw88: firmware recovery fixes and LPS hang handling
Date: Wed, 11 Nov 2026 07:28:28 +0100 [thread overview]
Message-ID: <7243D84A-CB81-477E-9A87-05AA4B3D0892@linux.dev> (raw)
In-Reply-To: <3fa52468b46142639eb6800cb52b146c@realtek.com>
On November 11, 2026 4:37:18 AM GMT+01:00, Ping-Ke Shih
<pkshih@realtek.com> wrote:
>Kalpesh Solanki <skalpesh942@gmail.com> wrote:
>> Changes in v4:
>> - In patch 1/3: Also clear RTW_FLAG_RESTARTING in rtw_ops_start() if
>> rtw_core_start() fails.
>> - Add patch 2/3: Prevent double free and sta_cnt underflow in
>> rtw_sta_remove() when recovery races with station disconnect.
>> - In patch 3/3:
>> - Keep rtw_fw_dump_dbg_info() in place on first failure.
>> - Restrict firmware recovery invocation to PCIe devices to prevent
>> scheduling while atomic panic on USB and SDIO.
>> - Explicitly check rtw_hci_type() in rtw_fw_recovery().
>
>I can't see v4 in lore nor patchwork. Please send v5 (identical to v4).
>
>
Shouldn't Kalpesh address the review comments before pushing v5 so we don't
waste a version cycle? He mentioned he'd follow up in a few days with v5 to
address the v4 feedback.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-11-11 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:27 [PATCH v4 0/3] wifi: rtw88: firmware recovery fixes and LPS hang handling Kalpesh Solanki
2026-11-08 14:27 ` [PATCH v4 1/3] wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start failure Kalpesh Solanki
2026-11-09 7:05 ` Luka Gejak
2026-11-08 14:27 ` [PATCH v4 2/3] wifi: rtw88: skip already reset station in rtw_sta_remove() Kalpesh Solanki
2026-11-09 7:11 ` Luka Gejak
2026-11-08 14:27 ` [PATCH v4 3/3] wifi: rtw88: ps: trigger firmware recovery only after consecutive LPS leave failures on PCI Kalpesh Solanki
2026-11-09 7:13 ` Luka Gejak
[not found] ` <CADYuhkqCNQxevZih3D+Zu-HcuyOao99iF31+Y6kDP0iM_Rr1kQ@mail.gmail.com>
2026-11-09 8:32 ` KALPESH SOLANKI
2026-11-09 8:42 ` Luka Gejak
2026-11-11 3:37 ` [PATCH v4 0/3] wifi: rtw88: firmware recovery fixes and LPS hang handling Ping-Ke Shih
2026-11-11 6:28 ` Luka Gejak [this message]
2026-11-11 6:44 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7243D84A-CB81-477E-9A87-05AA4B3D0892@linux.dev \
--to=luka.gejak@linux.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=skalpesh942@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.