From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A20AB329E44; Sat, 8 Aug 2026 15:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202849; cv=none; b=KkDVZhfIypXjo2GyVS1pBQ+fJq7RRER5qozyPsqFYA5Opd6bGGuf9iClPS4QNEGYVzQ6445kfpu9dzY9qTeZRnEVmfBzExkjFpXU2JUGKE0t/hU38lRQ4ufEpPzmOazrG4oI44X1AXSBkn6MxwqdBykTY7hCJHNXAb/Ox8wnPQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786202849; c=relaxed/simple; bh=O4wQA8+ZDQah5bMZ60+/73aucok37LcLMAF4TMHOVlc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r1rkdmee5VrWkCJOxVsIs2E4lB00Hiy1QVLD/NkTrm2ZW53eE1v5mPHINkMM+gbLLhEOxMZPouYHth8Ui7rFsYQ8gBCYFi9QAg+7Js8zfBXEGw/LHgzDlZWur5e0O5sKvnFcgpNvShKMyqkfBXVX+zjJcMfPNxO5OXXWq23SZQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Haayup0r; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Haayup0r" Message-ID: <724b2c8d-1481-4418-a10a-4331a620cd91@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786202834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SI4pVOEF8TdHC6SVL4QPbwdsQklGF+3daEeknr11Elk=; b=Haayup0raTU3WAhXIRdHDMl7W3bsfFO3rJCrSPSd/dELRqDTMLvLv4oO+idSX1JMzWQ6Dy f9uP2tByvoWXBCqJ9XWrmzqJo9qNp8JlpOD45A9dCA6E62owN0Kdmmuy/vgTnIinQAn6ip LddTPNHnN0AkIrmwYFqhpimG7O1pcdI= Date: Sat, 8 Aug 2026 16:26:16 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net 2/2] gve: fix NULL dereference due to missing ptp adjfine To: Harshitha Ramamurthy , netdev@vger.kernel.org Cc: joshwash@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, thostet@google.com, jordanrhee@google.com, ziweixiao@google.com, willemb@google.com, nktgrg@google.com, pkaligineedi@google.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260807224315.234152-1-hramamurthy@google.com> <20260807224315.234152-3-hramamurthy@google.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20260807224315.234152-3-hramamurthy@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 07/08/2026 23:43, Harshitha Ramamurthy wrote: > From: Jordan Rhee > > Fix NULL dereference due to missing implementation of adjfine, which can > be triggered from usermode as follows: > > sudo ./testptp -d /dev/ptp0 -f 0 > [ 551.943697] BUG: kernel NULL pointer dereference, address: 0000000000000000 > [...] > [ 552.061946] Call Trace: > [ 552.064487] > [ 552.066681] ptp_clock_adjtime+0x1c0/0x2c0 > [ 552.070874] ? get_clock_desc+0x6b/0xb0 > [ 552.074825] pc_clock_adjtime+0x78/0xc0 > [ 552.078755] __do_sys_clock_adjtime+0x85/0x110 > [ 552.083293] do_syscall_64+0xea/0x610 > > Cc: stable@vger.kernel.org > Fixes: acd16380523b ("gve: Add initial PTP device support") > Signed-off-by: Jordan Rhee > Signed-off-by: Harshitha Ramamurthy > --- > drivers/net/ethernet/google/gve/gve_ptp.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/google/gve/gve_ptp.c b/drivers/net/ethernet/google/gve/gve_ptp.c > index 06b1cf4a5efc..1d6c59f4ead3 100644 > --- a/drivers/net/ethernet/google/gve/gve_ptp.c > +++ b/drivers/net/ethernet/google/gve/gve_ptp.c > @@ -26,6 +26,11 @@ int gve_clock_nic_ts_read(struct gve_priv *priv) > return 0; > } > > +static int gve_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > +{ > + return -EOPNOTSUPP; > +} > + > static int gve_ptp_gettimex64(struct ptp_clock_info *info, > struct timespec64 *ts, > struct ptp_system_timestamp *sts) > @@ -60,6 +65,7 @@ static long gve_ptp_do_aux_work(struct ptp_clock_info *info) > static const struct ptp_clock_info gve_ptp_caps = { > .owner = THIS_MODULE, > .name = "gve clock", > + .adjfine = gve_ptp_adjfine, > .gettimex64 = gve_ptp_gettimex64, > .settime64 = gve_ptp_settime64, > .do_aux_work = gve_ptp_do_aux_work, .adjtime has to be implemented as well - neither adjfine nor adjtime are checked within ptp_clock_adjtime()