From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48C92C433F5 for ; Tue, 14 Dec 2021 14:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hj/IIKIHqOK47MBJZ4xhfNeqhbGW8fxnM8kjbcccOdI=; b=1LXJ35vlwfxVaHYlHOpgetDMVy mnDRPlgrN/yzK+0bQe+Xa+8lHJX2jpZ46Pxeziytjwc0QasikvnVtgM5o6YCa8fDVOo80iKazNARR ni0nvMV/LbkvGAjKcWX2wJwgha6wbfL6XuzG1XdjUu5qvSiCP/OnJ04OX2FOTCYyKWmtPawepykcd vpLGoSHctp0DlZl9OSNkfJg8rHbTxaAcOtxyAUIiQuMHYVbpFKSlyCVRH7IoZFl9ti/aE5W432Hwo Ds9iDj9TCfa4JDgcdKkWAU/nD7h6lDjAtbsjwgfmjLqHTONiMEdWNO6mTebc/s5f1IZiWwvZZkinG yYJKDy7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx8ld-00EOjG-51; Tue, 14 Dec 2021 14:26:57 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx8la-00EOhg-Hi for ath11k@lists.infradead.org; Tue, 14 Dec 2021 14:26:56 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1639492013; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=8DFXaG5fcOQYfue5yzmv/CTrkOnFnzNaBEkUAmBz840=; b=PUwdMdZ1fj6CcLFY5XJPr6sQso8H+CnABx62gk1Hk9/EuUNPTq7s6N7z4Vsk3BKVX7GipOCT X6GPR94kvRoRKNhGd0igv/Zjml3F2GIzkW972fwW2zn84xy5REJ5L+cFKrChw2fzfWnq+SFG 2LRNsIWfj2AiIU2GnNwRjzArjIk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 61b8a9ac4c698e2e81959f75 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 14 Dec 2021 14:26:52 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CA92AC43617; Tue, 14 Dec 2021 14:26:51 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: akolli) by smtp.codeaurora.org (Postfix) with ESMTPSA id AD7E5C4338F; Tue, 14 Dec 2021 14:26:50 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 14 Dec 2021 19:56:50 +0530 From: Anilkumar Kolli To: Dan Carpenter Cc: ath11k@lists.infradead.org Subject: Re: [bug report] ath11k: Fix pktlog lite rx events In-Reply-To: <20211130104159.GD5827@kili> References: <20211130104159.GD5827@kili> Message-ID: <725a45b8c05ebd508df3bfc6b1097b03@codeaurora.org> X-Sender: akolli@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_062654_678207_620116C3 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 2021-11-30 16:12, Dan Carpenter wrote: > Hello Anilkumar Kolli, > > The patch ab18e3bc1c13: "ath11k: Fix pktlog lite rx events" from Sep > 28, 2021, leads to the following Smatch static checker warning: > > drivers/net/wireless/ath/ath11k/dp_rx.c:3105 > ath11k_dp_rx_process_mon_status() > error: uninitialized symbol 'rx_buf_sz'. > > drivers/net/wireless/ath/ath11k/dp_rx.c > 3043 int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, > int mac_id, > 3044 struct napi_struct *napi, > int budget) > 3045 { > 3046 struct ath11k *ar = ath11k_ab_to_ar(ab, mac_id); > 3047 enum hal_rx_mon_status hal_status; > 3048 struct sk_buff *skb; > 3049 struct sk_buff_head skb_list; > 3050 struct hal_rx_mon_ppdu_info ppdu_info; > 3051 struct ath11k_peer *peer; > 3052 struct ath11k_sta *arsta; > 3053 int num_buffs_reaped = 0; > 3054 u32 rx_buf_sz; > ^^^^^^^^^^^^^ > > 3055 u16 log_type = 0; > 3056 > 3057 __skb_queue_head_init(&skb_list); > 3058 > 3059 num_buffs_reaped = > ath11k_dp_rx_reap_mon_status_ring(ab, mac_id, &budget, > 3060 > &skb_list); > 3061 if (!num_buffs_reaped) > 3062 goto exit; > 3063 > 3064 while ((skb = __skb_dequeue(&skb_list))) { > 3065 memset(&ppdu_info, 0, sizeof(ppdu_info)); > 3066 ppdu_info.peer_id = HAL_INVALID_PEERID; > 3067 > 3068 if > (ath11k_debugfs_is_pktlog_lite_mode_enabled(ar)) { > 3069 log_type = ATH11K_PKTLOG_TYPE_LITE_RX; > 3070 rx_buf_sz = DP_RX_BUFFER_SIZE_LITE; > 3071 } else if > (ath11k_debugfs_is_pktlog_rx_stats_enabled(ar)) { > 3072 log_type = > ATH11K_PKTLOG_TYPE_RX_STATBUF; > 3073 rx_buf_sz = DP_RX_BUFFER_SIZE; > 3074 } > > No else statement. > > 3075 > 3076 if (log_type) > 3077 trace_ath11k_htt_rxdesc(ar, > skb->data, log_type, rx_buf_sz); > 3078 > 3079 hal_status = > ath11k_hal_rx_parse_mon_status(ab, &ppdu_info, skb); > 3080 > 3081 if (ppdu_info.peer_id == HAL_INVALID_PEERID || > 3082 hal_status != HAL_RX_MON_STATUS_PPDU_DONE) > { > 3083 dev_kfree_skb_any(skb); > 3084 continue; > 3085 } > 3086 > 3087 rcu_read_lock(); > 3088 spin_lock_bh(&ab->base_lock); > 3089 peer = ath11k_peer_find_by_id(ab, > ppdu_info.peer_id); > 3090 > 3091 if (!peer || !peer->sta) { > 3092 ath11k_dbg(ab, ATH11K_DBG_DATA, > 3093 "failed to find the peer > with peer_id %d\n", > 3094 ppdu_info.peer_id); > 3095 spin_unlock_bh(&ab->base_lock); > 3096 rcu_read_unlock(); > 3097 dev_kfree_skb_any(skb); > 3098 continue; > 3099 } > 3100 > 3101 arsta = (struct ath11k_sta > *)peer->sta->drv_priv; > 3102 ath11k_dp_rx_update_peer_stats(arsta, > &ppdu_info); > 3103 > 3104 if (ath11k_debugfs_is_pktlog_peer_valid(ar, > peer->addr)) > --> 3105 trace_ath11k_htt_rxdesc(ar, > skb->data, log_type, rx_buf_sz); > > ^^^^^^^^^ > Warning here. > > 3106 > 3107 spin_unlock_bh(&ab->base_lock); > 3108 rcu_read_unlock(); > 3109 > 3110 dev_kfree_skb_any(skb); > 3111 } > 3112 exit: > 3113 return num_buffs_reaped; > 3114 } > > regards, > dan carpenter Hi Dan carpenter Thanks for reporting issue. Could you please help in reproducing the issue, I tried to reproduce the warnings using command, but could not make C=1 CHECK="smatch -p=kernel" -C. drivers/net/wireless/ath/ath11k/ modules My PC has, gcc --version gcc (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 sparse --version v0.6.3-rc1 smatch --version v0.5.0-7764-g0951ed59 Build LOGS: drivers/net/wireless/ath/ath11k/dp.c:213 ath11k_dp_srng_msi_setup() error: uninitialized symbol 'addr_lo'. drivers/net/wireless/ath/ath11k/dp.c:214 ath11k_dp_srng_msi_setup() error: uninitialized symbol 'addr_hi'. CHECK drivers/net/wireless/ath/ath11k/dp_tx.c CHECK drivers/net/wireless/ath/ath11k/dp_rx.c drivers/net/wireless/ath/ath11k/dp_rx.c:5372 ath11k_dp_rx_full_mon_deliver_ppdu() error: uninitialized symbol 'ret'. Thanks Anil. -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k