diff for duplicates of <7262598.5pX8AAxUPK@diego> diff --git a/a/1.txt b/N1/1.txt index a399cf2..1551c21 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,41 +1,32 @@ Am Donnerstag, 28. Januar 2016, 00:23:24 schrieb Stephen Boyd: -> On 01/21, Emilio L=F3pez wrote: -> > @@ -3059,7 +3069,25 @@ struct clk *__of_clk_get_from_provider(struc= -t -> > of_phandle_args *clkspec,>=20 +> On 01/21, Emilio L?pez wrote: +> > @@ -3059,7 +3069,25 @@ struct clk *__of_clk_get_from_provider(struct +> > of_phandle_args *clkspec,> > > */ -> > =20 -> > struct clk *of_clk_get_from_provider(struct of_phandle_args *clksp= -ec) +> > +> > struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec) > > { -> >=20 -> > -=09return __of_clk_get_from_provider(clkspec, NULL, __func__); -> > +=09return __of_clk_get_from_provider(clkspec, NULL, __func__, fals= -e); +> > +> > - return __of_clk_get_from_provider(clkspec, NULL, __func__); +> > + return __of_clk_get_from_provider(clkspec, NULL, __func__, false); > > +} > > + > > +/** -> > + * of_clk_get_from_provider_with_orphans() - Lookup clock from a c= -lock +> > + * of_clk_get_from_provider_with_orphans() - Lookup clock from a clock > > provider + * @clkspec: pointer to a clock specifier data structure > > + * -> > + * This function looks up a struct clk from the registered list of= - clock -> > + * providers, an input is a clock specifier data structure as retu= -rned +> > + * This function looks up a struct clk from the registered list of clock +> > + * providers, an input is a clock specifier data structure as returned > > + * from the of_parse_phandle_with_args() function call. > > + * -> > + * The difference to of_clk_get_from_provider() is that this funct= -ion +> > + * The difference to of_clk_get_from_provider() is that this function > > will -> > + * also successfully lookup orphan-clocks, as it in some cases may= - be +> > + * also successfully lookup orphan-clocks, as it in some cases may be > > + * necessary to access such orphan-clocks as well. > > + */ > > +struct clk * -> > +of_clk_get_from_provider_with_orphans(struct of_phandle_args *clks= -pec) ->=20 +> > +of_clk_get_from_provider_with_orphans(struct of_phandle_args *clkspec) +> > Dislike. In fact, the whole clk conf approach is odd here. When > we're doing of_clk_init() we do a best effort loop around > parent_ready(), waiting for clk providers to register as long as @@ -43,41 +34,28 @@ pec) > something similar in the non of_clk_init() case too, because > of_clk_init() isn't special. -At least to me being able to reparent orphan clocks when knowing that t= -hey=20 +At least to me being able to reparent orphan clocks when knowing that they won't ever get supplied is special. -The Rockchip clock controller has quite a number of clocks that can eit= -her be=20 -supplied by some external source. xin32k supplied by some i2c chip bein= -g the=20 -most prominent. But while this one will get supplied eventually, there = -are=20 +The Rockchip clock controller has quite a number of clocks that can either be +supplied by some external source. xin32k supplied by some i2c chip being the +most prominent. But while this one will get supplied eventually, there are others who will never get a supply and stay orphans forever. Example: -rk3288 sclk_edp_24m can get supplied by either the general 24MHz oscill= -ator or=20 -some separate clock input connected some chip pin. Reset-default seems = -to be=20 -the external supply, but on all boards I've seen so far doesn't get con= -nected. +rk3288 sclk_edp_24m can get supplied by either the general 24MHz oscillator or +some separate clock input connected some chip pin. Reset-default seems to be +the external supply, but on all boards I've seen so far doesn't get connected. -So we know on a per-board level if this is connected and want to move a= -way=20 -from the non-existent source. Which is why the limit of this new functi= -on is=20 +So we know on a per-board level if this is connected and want to move away +from the non-existent source. Which is why the limit of this new function is limited to be ccf internal and the assigned-clock-parents path. -I guess if you really dislike that approach the other option would be=20= - -reparenting all the time in the clock-controller driver and then let th= -e=20 -board-dts reparent back if needed. Which would also work for that clock= -, but=20 -may cause other glitches down the road when it affects some pre-setup t= -hings. +I guess if you really dislike that approach the other option would be +reparenting all the time in the clock-controller driver and then let the +board-dts reparent back if needed. Which would also work for that clock, but +may cause other glitches down the road when it affects some pre-setup things. > Furthermore, the assigned parents and rates feature doesn't need @@ -91,7 +69,7 @@ hings. > tree can be configured. Running the configuration at the end of > of_clk_init() even if we still can't get the clocks doesn't make > any sense to me. ->=20 +> > To be really nice, we could build up a set of configuration > actions (set this parent, set this rate), and run those actions > when we drop the orphan flag. If some clock is orphaned that diff --git a/a/content_digest b/N1/content_digest index 3eb3bbe..b1d2c71 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,56 +1,41 @@ "ref\01453385439-10154-1-git-send-email-emilio.lopez@collabora.co.uk\0" "ref\01453385958-11366-1-git-send-email-emilio.lopez@collabora.co.uk\0" "ref\020160128082324.GG12841@codeaurora.org\0" - "From\0Heiko St\303\274bner <heiko@sntech.de>\0" - "Subject\0Re: [PATCH 2/2] clk: defer clk_gets on orphan clocks\0" + "From\0heiko@sntech.de (Heiko St\303\274bner)\0" + "Subject\0[PATCH 2/2] clk: defer clk_gets on orphan clocks\0" "Date\0Thu, 28 Jan 2016 10:03:19 +0100\0" - "To\0Stephen Boyd <sboyd@codeaurora.org>\0" - "Cc\0Emilio L\303\263pez <emilio.lopez@collabora.co.uk>" - mturquette@baylibre.com - maxime.ripard@free-electrons.com - wens@csie.org - linux-clk@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Am Donnerstag, 28. Januar 2016, 00:23:24 schrieb Stephen Boyd:\n" - "> On 01/21, Emilio L=F3pez wrote:\n" - "> > @@ -3059,7 +3069,25 @@ struct clk *__of_clk_get_from_provider(struc=\n" - "t\n" - "> > of_phandle_args *clkspec,>=20\n" + "> On 01/21, Emilio L?pez wrote:\n" + "> > @@ -3059,7 +3069,25 @@ struct clk *__of_clk_get_from_provider(struct\n" + "> > of_phandle_args *clkspec,> \n" "> > */\n" - "> > =20\n" - "> > struct clk *of_clk_get_from_provider(struct of_phandle_args *clksp=\n" - "ec)\n" + "> > \n" + "> > struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec)\n" "> > {\n" - "> >=20\n" - "> > -=09return __of_clk_get_from_provider(clkspec, NULL, __func__);\n" - "> > +=09return __of_clk_get_from_provider(clkspec, NULL, __func__, fals=\n" - "e);\n" + "> > \n" + "> > -\treturn __of_clk_get_from_provider(clkspec, NULL, __func__);\n" + "> > +\treturn __of_clk_get_from_provider(clkspec, NULL, __func__, false);\n" "> > +}\n" "> > +\n" "> > +/**\n" - "> > + * of_clk_get_from_provider_with_orphans() - Lookup clock from a c=\n" - "lock\n" + "> > + * of_clk_get_from_provider_with_orphans() - Lookup clock from a clock\n" "> > provider + * @clkspec: pointer to a clock specifier data structure\n" "> > + *\n" - "> > + * This function looks up a struct clk from the registered list of=\n" - " clock\n" - "> > + * providers, an input is a clock specifier data structure as retu=\n" - "rned\n" + "> > + * This function looks up a struct clk from the registered list of clock\n" + "> > + * providers, an input is a clock specifier data structure as returned\n" "> > + * from the of_parse_phandle_with_args() function call.\n" "> > + *\n" - "> > + * The difference to of_clk_get_from_provider() is that this funct=\n" - "ion\n" + "> > + * The difference to of_clk_get_from_provider() is that this function\n" "> > will\n" - "> > + * also successfully lookup orphan-clocks, as it in some cases may=\n" - " be\n" + "> > + * also successfully lookup orphan-clocks, as it in some cases may be\n" "> > + * necessary to access such orphan-clocks as well.\n" "> > + */\n" "> > +struct clk *\n" - "> > +of_clk_get_from_provider_with_orphans(struct of_phandle_args *clks=\n" - "pec)\n" - ">=20\n" + "> > +of_clk_get_from_provider_with_orphans(struct of_phandle_args *clkspec)\n" + "> \n" "> Dislike. In fact, the whole clk conf approach is odd here. When\n" "> we're doing of_clk_init() we do a best effort loop around\n" "> parent_ready(), waiting for clk providers to register as long as\n" @@ -58,41 +43,28 @@ "> something similar in the non of_clk_init() case too, because\n" "> of_clk_init() isn't special.\n" "\n" - "At least to me being able to reparent orphan clocks when knowing that t=\n" - "hey=20\n" + "At least to me being able to reparent orphan clocks when knowing that they \n" "won't ever get supplied is special.\n" "\n" - "The Rockchip clock controller has quite a number of clocks that can eit=\n" - "her be=20\n" - "supplied by some external source. xin32k supplied by some i2c chip bein=\n" - "g the=20\n" - "most prominent. But while this one will get supplied eventually, there =\n" - "are=20\n" + "The Rockchip clock controller has quite a number of clocks that can either be \n" + "supplied by some external source. xin32k supplied by some i2c chip being the \n" + "most prominent. But while this one will get supplied eventually, there are \n" "others who will never get a supply and stay orphans forever.\n" "\n" "Example:\n" - "rk3288 sclk_edp_24m can get supplied by either the general 24MHz oscill=\n" - "ator or=20\n" - "some separate clock input connected some chip pin. Reset-default seems =\n" - "to be=20\n" - "the external supply, but on all boards I've seen so far doesn't get con=\n" - "nected.\n" + "rk3288 sclk_edp_24m can get supplied by either the general 24MHz oscillator or \n" + "some separate clock input connected some chip pin. Reset-default seems to be \n" + "the external supply, but on all boards I've seen so far doesn't get connected.\n" "\n" - "So we know on a per-board level if this is connected and want to move a=\n" - "way=20\n" - "from the non-existent source. Which is why the limit of this new functi=\n" - "on is=20\n" + "So we know on a per-board level if this is connected and want to move away \n" + "from the non-existent source. Which is why the limit of this new function is \n" "limited to be ccf internal and the assigned-clock-parents path.\n" "\n" "\n" - "I guess if you really dislike that approach the other option would be=20=\n" - "\n" - "reparenting all the time in the clock-controller driver and then let th=\n" - "e=20\n" - "board-dts reparent back if needed. Which would also work for that clock=\n" - ", but=20\n" - "may cause other glitches down the road when it affects some pre-setup t=\n" - "hings.\n" + "I guess if you really dislike that approach the other option would be \n" + "reparenting all the time in the clock-controller driver and then let the \n" + "board-dts reparent back if needed. Which would also work for that clock, but \n" + "may cause other glitches down the road when it affects some pre-setup things.\n" "\n" "\n" "> Furthermore, the assigned parents and rates feature doesn't need\n" @@ -106,7 +78,7 @@ "> tree can be configured. Running the configuration at the end of\n" "> of_clk_init() even if we still can't get the clocks doesn't make\n" "> any sense to me.\n" - ">=20\n" + "> \n" "> To be really nice, we could build up a set of configuration\n" "> actions (set this parent, set this rate), and run those actions\n" "> when we drop the orphan flag. If some clock is orphaned that\n" @@ -119,4 +91,4 @@ "> last part may be over-engineered though. I'm not sure if we\n" > really have any such scenario today. -6d79212260967278ea66414626e085eda0bf12a9ef3aff86d56f4a5212b28a52 +94330df3e17531eebbd760e713e4713ca193e10ca8105e13dec5d8653bf059eb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.