From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 05/18] OMAP5: palmas: Configure nominal opp vdd values
Date: Thu, 8 Mar 2012 11:13:21 +0530 [thread overview]
Message-ID: <72857ee290e66b84814f819dca81c725@mail.gmail.com> (raw)
In-Reply-To: <CA+M6bXnFyVKQ=60QY7av5Ft4OxfoWjwVCWN3GJ+EftXwo7mA8g@mail.gmail.com>
Hi,
> -----Original Message-----
> From: tom.rini at gmail.com [mailto:tom.rini at gmail.com] On Behalf Of Tom
> Rini
> Sent: Thursday, March 08, 2012 2:04 AM
> To: Menon, Nishanth; sricharan
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH V2 05/18] OMAP5: palmas: Configure nominal
> opp vdd values
>
> On Wed, Mar 7, 2012 at 11:19 AM, Menon, Nishanth <nm@ti.com> wrote:
> > On Wed, Mar 7, 2012 at 11:04, Tom Rini <trini@ti.com> wrote:
> >> On Thu, Mar 01, 2012 at 08:08:30PM +0530, R Sricharan wrote:
> >>
> >>> The nominal opp vdd values as recommended for
> >>> ES1.0 silicon is set for mpu, core, mm domains using palmas.
> >>
> >> OK, this creates some trivial conflicts with
> >> http://patchwork.ozlabs.org/patch/144137/ but also raises a
> functional
> >> problem / question. ?Is this patch also changing the order to match
> what
> >> Nishanth did or does this patch also need that functional change
> done
> >> (and a v3) ? ?Thanks!
> > Glancing at this patch, I see that scale sequence is still mpu, core,
> > MM - which is what my sequence fixes. will be nice to have the
> > sequence fixed followed by cleanup/update to retain the sequence
> > appropriately.
> >
> > + ? ? ? /* Palmas settings */
> > + ? ? ? volt = VDD_MPU;
> > + ? ? ? do_scale_vcore(SMPS_REG_ADDR_12_MPU, volt);
> >
> > - ? ? ? /* VCORE 1 - for vdd_core */
> > - ? ? ? volt = 1000;
> > - ? ? ? do_scale_vcore(SMPS_REG_ADDR_VCORE1, volt);
> > + ? ? ? volt = VDD_MM;
> > + ? ? ? do_scale_vcore(SMPS_REG_ADDR_45_IVA, volt);
> >
> > - ? ? ? /* VCORE 2 - for vdd_MM */
> > - ? ? ? volt = 1125;
> > - ? ? ? do_scale_vcore(SMPS_REG_ADDR_VCORE2, volt);
> > + ? ? ? volt = VDD_CORE;
> > + ? ? ? do_scale_vcore(SMPS_REG_ADDR_8_CORE, volt);
>
> I think what might be easiest all around is to drop Nishanth's 4/4 and
> have patch 5 here correct the order as well, crediting Nishanth for
> the fix. Alternatively, respin the series, depending on Nishanth's
> series being applied. Thanks.
I can quickly do your first suggestion.
This can reduce the number of patches and make them ordered
as well.
>
> --
> Tom
next prev parent reply other threads:[~2012-03-08 5:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 14:38 [U-Boot] [PATCH V2 00/18] OMAP5: Add the Changes required for OMAP5 ES1.0 silicon R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 01/18] OMAP5: clocks: Change clock settings as required for " R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 02/18] OMAP5: board: Add pinmux data for omap5_evm board R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 03/18] OMAP5: io: Configure the io settings for omap5430 sevm board R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 04/18] OMAP5: emif/ddr: Change emif settings as required for ES1.0 silicon R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 05/18] OMAP5: palmas: Configure nominal opp vdd values R Sricharan
2012-03-07 17:04 ` Tom Rini
2012-03-07 18:19 ` Menon, Nishanth
2012-03-07 20:34 ` Tom Rini
2012-03-08 5:37 ` Menon, Nishanth
2012-03-08 5:43 ` Sricharan R [this message]
2012-03-01 14:38 ` [U-Boot] [PATCH V2 06/18] OMAP5: hwinit: Add the missing break statement R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 07/18] OMAP4/5: Make the silicon revision variable common R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 08/18] OMAP5: SRAM: Change the SRAM base address R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 09/18] OMAP4/5: Make the sysctrl structure common R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 10/18] OMAP4/5: device: Add support to get the device type R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 11/18] OMAP5: defconfig: Align the defconfig for 5430 ES1.0 R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 12/18] OMAP5: ddr: Change the ddr device name R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 13/18] OMAP4/5: emif: Correct the emif power mgt shadow register bit fields R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 14/18] arm: omap5: correct boot device mode7 for eMMC R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 15/18] power: twl6035: add palmas PMIC support R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 16/18] omap5: pbias ldo9 turn on R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 17/18] mmc: omap5evm: Add eMMC saveenv support R Sricharan
2012-03-01 14:38 ` [U-Boot] [PATCH V2 18/18] OMAP5: reset: Use cold reset in case of 5430ES1.0 R Sricharan
2012-03-05 17:42 ` Tom Rini
2012-03-05 17:43 ` [U-Boot] [PATCH V2 00/18] OMAP5: Add the Changes required for OMAP5 ES1.0 silicon Tom Rini
2012-03-06 6:20 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72857ee290e66b84814f819dca81c725@mail.gmail.com \
--to=r.sricharan@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.