From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 08/16] Add support for mapping devices through VFIO. Date: Thu, 22 May 2014 14:46:08 +0200 Message-ID: <7296546.Pqjxyb6pDa@xps13> References: <1871082.JnAAVjVYKa@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Burakov, Anatoly" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-22 12:37, Burakov, Anatoly: > > Yes, in some environments, it could be easier to be able to configure > > devices directly on application command line instead of having to call a > > python script. I think having a clear and extendable syntax to configure > > devices in command line could greatly improve usability. But it can be > > another step. > > That's probably out of scope for this patch. We can discuss this later > without stalling VFIO :) Yes, I agree to discuss it later. > > What do you think of _mp_sync or _mp_conf? > > Usage of the socket is to synchronize VFIO config between processes, > > right? > > More or less, yes. However, the code inside that file is the communication > mechanism. I.e. it's not actually synchronizing or configuring anything, > it's simply providing means to do so for primary and secondary processes, > so I don't think _mp_sync or _mp_conf is a good name for that. IMO > something like _mp_socket or similar (_mp_comm?) would be more appropriate. Yes I agree. But I stopped on the name for another thing: it's not really specific to vfio. Actually, vfio uses it for synchronization. But wouldn't it be more generic? -- Thomas