From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/16] drm/i915/gmbus: Reset the controller on initialisation Date: Fri, 13 May 2011 16:53:43 +0100 Message-ID: <72a37e$j4ij65@orsmga002.jf.intel.com> References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-10-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A2629E7E7 for ; Fri, 13 May 2011 08:53:46 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 13 May 2011 08:01:51 -0700, Keith Packard wrote: > On Fri, 13 May 2011 10:32:25 +0100, Chris Wilson wrote: > > > It has been booting daily on several machines for a month. I agree it > > wouldn't have worked, but the since we automatically fallback to GPIO > > should it go south, the failures didn't stop the external monitors from > > being lit up. > > Yeah, nice that we fall back. Do we want a warning in the kernel log > when that happens (once, not multiple times)? At least some way to > verify that the new code is doing what we expect it to do. We give a warning when we fail a GMBUS sequence and switch (permanently) to using GPIO. I've been desensitised to those warnings, because there is sometimes, depending upon the hardware and probes, one channel which fails. The fact that I'd so utterly broken the code didn't occur to me. -Chris -- Chris Wilson, Intel Open Source Technology Centre