All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nilay Shroff <nilay@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, hare@suse.de, dwagner@suse.de,
	wenxiong@linux.ibm.com, gjoyce@ibm.com
Subject: Re: [PATCH 1/7] nvme: export command retry count via sysfs
Date: Mon, 2 Feb 2026 19:03:33 +0530	[thread overview]
Message-ID: <72bf891f-5ffc-40aa-9b83-3e13065cabcd@linux.ibm.com> (raw)
In-Reply-To: <aX0VgduYJckUaZ3O@kbusch-mbp>



On 1/31/26 2:03 AM, Keith Busch wrote:
> On Fri, Jan 30, 2026 at 11:50:18PM +0530, Nilay Shroff wrote:
>>  	nvme_req(req)->retries++;
>> +	if (ns)
>> +		ns->retries++;
>> +	else
>> +		nvme_req(req)->ctrl->retries++;
> 
> I don't think admin commands ever retry with this driver, so probably
> not worth tracking it.
Yeah got it. I will drop retry counter for admin commands.
> 
> And as unlikely as it is to happen, might want to ensure it doesn't
> wrap back to zero. The size_add() function handles that.
Sure, makes sense. 

I will fix these in next patch revision.

Thanks,
--Nilay


  reply	other threads:[~2026-02-02 13:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30 18:20 [PATCH 0/7] nvme: export additional diagnostic counters via sysfs Nilay Shroff
2026-01-30 18:20 ` [PATCH 1/7] nvme: export command retry count " Nilay Shroff
2026-01-30 20:33   ` Keith Busch
2026-02-02 13:33     ` Nilay Shroff [this message]
2026-01-30 18:20 ` [PATCH 2/7] nvme: export multipath failover " Nilay Shroff
2026-01-30 18:20 ` [PATCH 3/7] nvme: export command error counters " Nilay Shroff
2026-01-30 18:20 ` [PATCH 4/7] nvme: export I/O requeue count when no path is available " Nilay Shroff
2026-01-30 18:20 ` [PATCH 5/7] nvme: export I/O failure " Nilay Shroff
2026-01-30 18:20 ` [PATCH 6/7] nvme: export controller reset event count " Nilay Shroff
2026-01-30 18:20 ` [PATCH 7/7] nvme: export controller reconnect " Nilay Shroff
2026-02-02 22:56 ` [PATCH 0/7] nvme: export additional diagnostic counters " Hannes Reinecke
2026-02-03  9:07   ` Nilay Shroff
2026-02-03 12:26 ` Ming Lei
2026-02-03 13:03   ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72bf891f-5ffc-40aa-9b83-3e13065cabcd@linux.ibm.com \
    --to=nilay@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=gjoyce@ibm.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=wenxiong@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.