Re: [PATCH] nvmet-auth: update sc_c in target host hash calculation

[Hannes Reinecke <hare@suse.de>]

On 10/29/25 12:20, Alistair Francis wrote:
> On Wed, Oct 29, 2025 at 6:10 PM Hannes Reinecke <hare@suse.de> wrote:
>>
>> On 10/29/25 05:53, alistair23@gmail.com wrote:
>>> From: Alistair Francis <alistair.francis@wdc.com>
>>>
>>> Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added
>>> the sc_c variable to the dhchap queue context structure which is
>>> appropriately set during negotiate and then used in the host response.
>>>
>>> This breaks secure concat connections with a Linux target as the target
>>> code wasn't updated at the same time. This patch fixes this by adding a
>>> new sc_c variable to the host hash calculations.
>>>
>>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>>> ---
>>>    drivers/nvme/host/auth.c               | 1 +
>>>    drivers/nvme/target/auth.c             | 3 ++-
>>>    drivers/nvme/target/fabrics-cmd-auth.c | 1 +
>>>    drivers/nvme/target/nvmet.h            | 1 +
>>>    4 files changed, 5 insertions(+), 1 deletion(-)
>>>
>> I've already send a similar patch for this, which actually should
>> already have been merged.
>> Can you check if that works for you?
> 
> I checked master when I sent this and there was nothing applied. Is it
> in a different tree?
> 

https://lore.kernel.org/linux-nvme/aPl4-6WQ940kUso7@kbusch-mbp/T/#t

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich