All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"aboyer@pensando.io" <aboyer@pensando.io>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"chas3@att.com" <chas3@att.com>,
	"chenbo.xia@intel.com" <chenbo.xia@intel.com>,
	"Loftus, Ciara" <ciara.loftus@intel.com>,
	"dsinghrawat@marvell.com" <dsinghrawat@marvell.com>,
	"Czeck, Ed" <ed.czeck@atomicrules.com>,
	"evgenys@amazon.com" <evgenys@amazon.com>,
	"grive@u256.net" <grive@u256.net>,
	 "g.singh@nxp.com" <g.singh@nxp.com>,
	"zhouguoyang@huawei.com" <zhouguoyang@huawei.com>,
	"Wang, Haiyue" <haiyue.wang@intel.com>,
	"hkalra@marvell.com" <hkalra@marvell.com>,
	"heinrich.kuhn@corigine.com" <heinrich.kuhn@corigine.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"hyonkim@cisco.com" <hyonkim@cisco.com>,
	"igorch@amazon.com" <igorch@amazon.com>,
	"irusskikh@marvell.com" <irusskikh@marvell.com>,
	"jgrajcia@cisco.com" <jgrajcia@cisco.com>,
	"Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"jianwang@trustnetic.com" <jianwang@trustnetic.com>,
	"jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"johndale@cisco.com" <johndale@cisco.com>,
	"john.miller@atomicrules.com" <john.miller@atomicrules.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"Wiles, Keith" <keith.wiles@intel.com>,
	"kirankumark@marvell.com" <kirankumark@marvell.com>,
	"oulijun@huawei.com" <oulijun@huawei.com>,
	"lironh@marvell.com" <lironh@marvell.com>,
	"longli@microsoft.com" <longli@microsoft.com>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"spinler@cesnet.cz" <spinler@cesnet.cz>,
	"matan@nvidia.com" <matan@nvidia.com>,
	"Peters, Matt" <matt.peters@windriver.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"mk@semihalf.com" <mk@semihalf.com>,
	"humin (Q)" <humin29@huawei.com>,
	"pnalla@marvell.com" <pnalla@marvell.com>,
	"ndabilpuram@marvell.com" <ndabilpuram@marvell.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"radhac@marvell.com" <radhac@marvell.com>,
	"rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
	"rmody@marvell.com" <rmody@marvell.com>,
	"Xu,  Rosen" <rosen.xu@intel.com>,
	"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
	"skoteshwar@marvell.com" <skoteshwar@marvell.com>,
	"shshaikh@marvell.com" <shshaikh@marvell.com>,
	"shaibran@amazon.com" <shaibran@amazon.com>,
	"Siegel, Shepard" <shepard.siegel@atomicrules.com>,
	"asomalap@amd.com" <asomalap@amd.com>,
	"somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>,
	"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
	"Webster, Steven" <steven.webster@windriver.com>,
	"skori@marvell.com" <skori@marvell.com>,
	"mtetsuyah@gmail.com" <mtetsuyah@gmail.com>,
	"vburru@marvell.com" <vburru@marvell.com>,
	"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>,
	"Wang, Xiao W" <xiao.w.wang@intel.com>,
	"Wangxiaoyun (Cloud)" <cloud.wangxiaoyun@huawei.com>,
	"Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
	"Wang, Yong" <yongwang@vmware.com>,
	"Xuanziyang (William)" <william.xuanziyang@huawei.com>
Subject: RE: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query
Date: Thu, 4 Jan 2024 14:21:50 +0000	[thread overview]
Message-ID: <72c8a6a8001e48159f4bbeac44847f26@huawei.com> (raw)
In-Reply-To: <CALBAE1OnY5n4UPT8Jnj4D16soXUktSjXqs8gxpJNf0LACFXSQg@mail.gmail.com>



> > > Introduce a new API to retrieve the number of available free descriptors
> > > in a Tx queue. Applications can leverage this API in the fast path to
> > > inspect the Tx queue occupancy and take appropriate actions based on the
> > > available free descriptors.
> > >
> > > A notable use case could be implementing Random Early Discard (RED)
> > > in software based on Tx queue occupancy.
> > >
> > > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > ---
> > >  doc/guides/nics/features.rst         | 10 ++++
> > >  doc/guides/nics/features/default.ini |  1 +
> > >  lib/ethdev/ethdev_trace_points.c     |  3 ++
> > >  lib/ethdev/rte_ethdev.h              | 78 ++++++++++++++++++++++++++++
> > >  lib/ethdev/rte_ethdev_core.h         |  7 ++-
> > >  lib/ethdev/rte_ethdev_trace_fp.h     |  8 +++
> > >  6 files changed, 106 insertions(+), 1 deletion(-)
> >
> > Hi Jerin,
> 
> Hi Cristian,
> 
> >
> > I think having an API to get the number of free descriptors per queue is a good idea. Why have it only for TX queues and not for RX
> queues as well?
> 
> I see no harm in adding for Rx as well. I think, it is better to have
> separate API for each instead of adding argument as it is fast path
> API.
> If so, we could add a new API when there is any PMD implementation or
> need for this.

I think for RX we already have similar one:
/** @internal Get number of used descriptors on a receive queue. */
typedef uint32_t (*eth_rx_queue_count_t)(void *rxq);

 


  reply	other threads:[~2024-01-04 14:21 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 17:29 [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query jerinj
2024-01-04 13:16 ` Dumitrescu, Cristian
2024-01-04 13:35   ` Jerin Jacob
2024-01-04 14:21     ` Konstantin Ananyev [this message]
2024-01-04 18:29       ` Thomas Monjalon
2024-01-05  9:57         ` Jerin Jacob
2024-01-05 10:03           ` Thomas Monjalon
2024-01-05 11:12             ` Konstantin Ananyev
2024-01-08 20:54               ` Morten Brørup
2024-01-09 14:45                 ` Jerin Jacob
2024-01-04 21:17 ` Thomas Monjalon
2024-01-05  9:54   ` Jerin Jacob
2024-01-05 10:02     ` Thomas Monjalon
2024-01-08 10:54 ` Bruce Richardson
2024-01-08 21:15   ` Morten Brørup
2024-01-09  8:47     ` Bruce Richardson
2024-01-12 10:56     ` Ferruh Yigit
2024-01-11 15:17 ` [dpdk-dev] [v1] ethdev: support Tx queue used count jerinj
2024-01-11 16:17   ` Andrew Rybchenko
2024-01-12  6:56     ` Jerin Jacob
2024-01-11 16:20   ` Morten Brørup
2024-01-12  6:59     ` Jerin Jacob
2024-01-11 17:00   ` Stephen Hemminger
2024-01-12  7:01     ` Jerin Jacob
2024-01-12 16:30       ` Stephen Hemminger
2024-01-12  8:02   ` David Marchand
2024-01-12  9:29     ` Jerin Jacob
2024-01-12 11:34   ` Ferruh Yigit
2024-01-12 12:11     ` David Marchand
2024-01-12 14:25       ` Ferruh Yigit
2024-01-12 12:29     ` Morten Brørup
2024-01-12 14:29       ` Ferruh Yigit
2024-01-18  9:06     ` Jerin Jacob
2024-01-12 12:33   ` Konstantin Ananyev
2024-01-16  6:37     ` Jerin Jacob
2024-01-18 10:17       ` Konstantin Ananyev
2024-01-18 11:21         ` Jerin Jacob
2024-01-18 13:36         ` Morten Brørup
2024-01-19  9:52           ` Konstantin Ananyev
2024-01-19 10:32             ` Morten Brørup
2024-01-12 16:52   ` Stephen Hemminger
2024-01-18  9:47   ` [dpdk-dev] [v2] " jerinj
2024-01-22 13:00     ` Konstantin Ananyev
2024-01-23 11:46       ` Ferruh Yigit
2024-02-07 20:30         ` Ferruh Yigit
2024-01-29 15:03     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72c8a6a8001e48159f4bbeac44847f26@huawei.com \
    --to=konstantin.ananyev@huawei.com \
    --cc=aboyer@pensando.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=asomalap@amd.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chas3@att.com \
    --cc=chenbo.xia@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ed.czeck@atomicrules.com \
    --cc=evgenys@amazon.com \
    --cc=ferruh.yigit@amd.com \
    --cc=ferruh.yigit@xilinx.com \
    --cc=g.singh@nxp.com \
    --cc=grive@u256.net \
    --cc=haiyue.wang@intel.com \
    --cc=heinrich.kuhn@corigine.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=igorch@amazon.com \
    --cc=irusskikh@marvell.com \
    --cc=jasvinder.singh@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=jgrajcia@cisco.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=johndale@cisco.com \
    --cc=keith.wiles@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=linville@tuxdriver.com \
    --cc=lironh@marvell.com \
    --cc=longli@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=matt.peters@windriver.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mk@semihalf.com \
    --cc=mtetsuyah@gmail.com \
    --cc=mw@semihalf.com \
    --cc=ndabilpuram@marvell.com \
    --cc=oulijun@huawei.com \
    --cc=pnalla@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=radhac@marvell.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=rmody@marvell.com \
    --cc=rosen.xu@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=shaibran@amazon.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=shshaikh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=spinler@cesnet.cz \
    --cc=steven.webster@windriver.com \
    --cc=sthemmin@microsoft.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    --cc=viacheslavo@nvidia.com \
    --cc=william.xuanziyang@huawei.com \
    --cc=xiao.w.wang@intel.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=yongwang@vmware.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.