All of lore.kernel.org
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: smp: Fix Unknown IPI message 0x1
Date: Mon, 17 Jan 2011 17:38:11 +0530	[thread overview]
Message-ID: <72ca984700f139fea98558783dde38f3@mail.gmail.com> (raw)
In-Reply-To: <20110117120104.GB20615@n2100.arm.linux.org.uk>

> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Monday, January 17, 2011 5:31 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH] ARM: smp: Fix Unknown IPI message 0x1
>
> On Mon, Jan 17, 2011 at 05:26:35PM +0530, Santosh Shilimkar wrote:
> > Commit 'ad3b6993' converted ARM smp_cross_call() to take IPI
> number
> > as a parameter to handle more event than SGI and do_IPI was
> suppose
> > to recover SGI number. But the do_IPI doesn't consider it and it's
> > getting detected as 'Unknown IPI message 0x1' with ipi numbers are
> > moved to starts from 'IPI_TIMER=2"
> >
> > There can be 16 different SGI but only SGI1 is used as IPI so
> > only that one is handled in do_IPI as IPI_CPU_START.
> >
> > Added IPI_CPU_START because it wasn't used and thought it's
> > appropriate. Not sure whether its the right one.
>
> Background:
> - we start at 2 because we don't know whether platforms have hard-
> wired
>   SGI1 for startup.
> - we don't trap SGI1 at all because we don't use it.
> - there's nothing stopping platforms using another SGI to wakeup -
> we
>   don't want to be adding more of this code.
>
OK.

> I'd much rather see platforms deciding whether they need to use SGI1
> or whether they can switch to SGI0 instead - and we make SGI0 be the
> "ignored wakeup" SGI.  If everyone can do that, we get rid of the
> silly offset entirely.

This should be ok. May be Catalin can comment on choice of SGI1 in
generic smp_cross_call().

I found below messge in boot which made me to make this patch.
'CPU1: Unknown IPI message 0x1'

Regards,
Santosh

  reply	other threads:[~2011-01-17 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 11:56 [PATCH] ARM: smp: Fix Unknown IPI message 0x1 Santosh Shilimkar
2011-01-17 12:01 ` Russell King - ARM Linux
2011-01-17 12:08   ` Santosh Shilimkar [this message]
2011-01-17 12:19     ` Russell King - ARM Linux
2011-01-17 12:26       ` Catalin Marinas
2011-01-17 12:31         ` Santosh Shilimkar
2011-01-17 12:34           ` Russell King - ARM Linux
2011-01-21 22:29             ` Jeff Ohlstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72ca984700f139fea98558783dde38f3@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.