All of lore.kernel.org
 help / color / mirror / Atom feed
From: isaacm@codeaurora.org
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, pratikp@codeaurora.org
Subject: Re: [PATCH v2 07/12] iommu: Hook up '->unmap_pages' driver callback
Date: Mon, 05 Apr 2021 12:22:05 -0700	[thread overview]
Message-ID: <72cf6c7ceff1ffbf84f596c7f877d4ab@codeaurora.org> (raw)
In-Reply-To: <0d1a6c6b-c523-8868-99c5-51c6a1e40cc4@linux.intel.com>

On 2021-04-04 23:00, Lu Baolu wrote:
> Hi,
> 
> On 4/2/21 9:34 AM, Isaac J. Manjarres wrote:
>>   static size_t __iommu_unmap(struct iommu_domain *domain,
>>   			    unsigned long iova, size_t size,
>>   			    struct iommu_iotlb_gather *iotlb_gather)
>> @@ -2476,7 +2519,7 @@ static size_t __iommu_unmap(struct iommu_domain 
>> *domain,
>>   	unsigned long orig_iova = iova;
>>   	unsigned int min_pagesz;
>>   -	if (unlikely(ops->unmap == NULL ||
>> +	if (unlikely((ops->unmap == NULL && ops->unmap_pages == NULL) ||
>>   		     domain->pgsize_bitmap == 0UL))
> 
> This change should also be applied to __iommu_map() path. And perhaps
> could be:
> 
> 	if (unlikely(!(ops->unmap || ops->unmap_pages) || 
> !domain->pgsize_bitmap))
> 
Yep, that's correct. Thank you for spotting that; I've updated it in the 
latest series: 
https://lore.kernel.org/linux-iommu/20210405191112.28192-1-isaacm@codeaurora.org/T/#t.

Thanks,
Isaac
> Best regards,
> baolu
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-04-05 19:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  1:34 [RFC PATCH v2 00/12] Optimizing iommu_[map/unmap] performance Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 01/12] iommu/io-pgtable: Introduce unmap_pages() as a page table op Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 02/12] iommu: Add an unmap_pages() op for IOMMU drivers Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 03/12] iommu/io-pgtable: Introduce map_pages() as a page table op Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 04/12] iommu: Add a map_pages() op for IOMMU drivers Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 05/12] iommu: Use bitmap to calculate page size in iommu_pgsize() Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 06/12] iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 07/12] iommu: Hook up '->unmap_pages' driver callback Isaac J. Manjarres
2021-04-05  6:00   ` Lu Baolu
2021-04-05  6:00     ` Lu Baolu
2021-04-05 19:22     ` isaacm [this message]
2021-04-02  1:34 ` [PATCH v2 08/12] iommu: Add support for the map_pages() callback Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 09/12] iommu/io-pgtable-arm: Implement arm_lpae_unmap_pages() Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 10/12] iommu/io-pgtable-arm: Implement arm_lpae_map_pages() Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 11/12] iommu/arm-smmu: Implement the unmap_pages() IOMMU driver callback Isaac J. Manjarres
2021-04-02  1:34 ` [PATCH v2 12/12] iommu/arm-smmu: Implement the map_pages() " Isaac J. Manjarres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72cf6c7ceff1ffbf84f596c7f877d4ab@codeaurora.org \
    --to=isaacm@codeaurora.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=pratikp@codeaurora.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.