From: Lance Yang <lance.yang@linux.dev>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-mm@kvack.org, Kiryl Shutsemau <kirill@shutemov.name>,
SeongJae Park <sj@kernel.org>,
dev.jain@arm.com, akpm@linux-foundation.org, baohua@kernel.org,
ryan.roberts@arm.com, david@redhat.com, xu.xin16@zte.com.cn,
chengming.zhou@linux.dev, npache@redhat.com,
Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com,
baolin.wang@linux.alibaba.com, ziy@nvidia.com
Subject: Re: [Patch v3 2/2] mm/khugepaged: remove definition of struct khugepaged_mm_slot
Date: Wed, 24 Sep 2025 11:18:52 +0800 [thread overview]
Message-ID: <72d3eaf2-09ec-4c87-a680-636cc578a32d@linux.dev> (raw)
In-Reply-To: <20250924004854.29889-3-richard.weiyang@gmail.com>
On 2025/9/24 08:48, Wei Yang wrote:
> Current code is not correct to get struct khugepaged_mm_slot by
> mm_slot_entry() without checking mm_slot is !NULL. There is no problem
> reported since slot is the first element of struct khugepaged_mm_slot.
>
> While struct khugepaged_mm_slot is just a wrapper of struct mm_slot, there
> is no need to define it.
>
> Remove the definition of struct khugepaged_mm_slot, so there is not chance
> to miss use mm_slot_entry().
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: Lance Yang <lance.yang@linux.dev>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Dev Jain <dev.jain@arm.com>
> Cc: Kiryl Shutsemau <kirill@shutemov.name>
> Cc: xu xin <xu.xin16@zte.com.cn>
> Cc: SeongJae Park <sj@kernel.org>
> Cc: Nico Pache <npache@redhat.com>
LGTM.
Acked-by: Lance Yang <lance.yang@linux.dev>
[..]
next prev parent reply other threads:[~2025-09-24 3:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 0:48 [Patch v3 0/2] mm_slot: fix the usage of mm_slot_entry Wei Yang
2025-09-24 0:48 ` [Patch v3 1/2] mm/ksm: get mm_slot by mm_slot_entry() when slot is !NULL Wei Yang
2025-09-24 2:19 ` Chengming Zhou
2025-09-24 9:35 ` Kiryl Shutsemau
2025-09-24 9:40 ` David Hildenbrand
2025-09-24 10:06 ` Kiryl Shutsemau
2025-09-24 10:09 ` David Hildenbrand
2025-09-24 10:15 ` Kiryl Shutsemau
2025-09-24 10:42 ` David Hildenbrand
2025-09-24 14:52 ` Wei Yang
2025-09-24 9:35 ` David Hildenbrand
2025-09-24 0:48 ` [Patch v3 2/2] mm/khugepaged: remove definition of struct khugepaged_mm_slot Wei Yang
2025-09-24 3:18 ` Lance Yang [this message]
2025-09-24 5:51 ` Dev Jain
2025-09-24 9:39 ` David Hildenbrand
2025-09-24 14:59 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d3eaf2-09ec-4c87-a680-636cc578a32d@linux.dev \
--to=lance.yang@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=sj@kernel.org \
--cc=xu.xin16@zte.com.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.