Re: [PATCH i-g-t, v5 3/3] tests/kms_atomic: skip BACKGROUND_COLOR in CRTC state checks

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Hey,

On 9/17/26 21:18, Swati Sharma wrote:
> BACKGROUND_COLOR is initialized to opaque black, while the generic CRTC
> state snapshot does not read it back. Comparing the property causes
> atomic tests to fail during setup. Exclude it from the generic state
> comparison while keeping the valid opaque default.
> 
> Assisted-by: GitHub Copilot:Claude Opus 4.6
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_atomic.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index ce5b00cd3..09b7915af 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -218,7 +218,8 @@ static void plane_commit_atomic_err(igt_plane_t *plane,
>  
>  static bool crtc_filter(enum igt_atomic_crtc_properties prop)
>  {
> -	if (prop == IGT_CRTC_MODE_ID || prop == IGT_CRTC_ACTIVE)
> +	if (prop == IGT_CRTC_MODE_ID || prop == IGT_CRTC_ACTIVE ||
> +	    prop == IGT_CRTC_BACKGROUND_COLOR)
>  		return false;
>  
>  	return true;

Seems reasonable.

If this happens again in the future, we should switch the test from a denylist to an allowlist.

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>