From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B346CC43464 for ; Fri, 18 Sep 2020 10:25:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 305EC208C3 for ; Fri, 18 Sep 2020 10:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a1jweCur" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 305EC208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJDZz-0004Jh-UP for qemu-devel@archiver.kernel.org; Fri, 18 Sep 2020 06:25:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJDYs-0003rQ-N2 for qemu-devel@nongnu.org; Fri, 18 Sep 2020 06:24:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJDYq-0003dO-Nc for qemu-devel@nongnu.org; Fri, 18 Sep 2020 06:24:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600424651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAMPedh2AIlCfVsWCPHe0HLPSIMznpNqhOhqrkFIpmA=; b=a1jweCur5mX+/jWsYusRP1cncnZgbM203yYCtxyMjdTGe6pOnx/PMYVQy4vB2UnF12oEx1 cUB3a/CWoQiOgjHN4b4wwV8CV8qlODqZgeE3G5IOM5SSN9B3NujEFetHvp7xk/MZ4p1Ewe bsWheqdeFHaVozxYM1jNobyMotULe4s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-8hnWeCvPMqCi1_JTHjI2Ig-1; Fri, 18 Sep 2020 06:24:10 -0400 X-MC-Unique: 8hnWeCvPMqCi1_JTHjI2Ig-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 819F3801AAB; Fri, 18 Sep 2020 10:24:08 +0000 (UTC) Received: from [10.36.112.29] (ovpn-112-29.ams2.redhat.com [10.36.112.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 522F45DEBE; Fri, 18 Sep 2020 10:24:04 +0000 (UTC) Subject: Re: [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1 To: Cornelia Huck References: <20200908193309.20569-1-eric.auger@redhat.com> <20200908193309.20569-3-eric.auger@redhat.com> <20200918112909.5f797bf4.cohuck@redhat.com> From: Auger Eric Message-ID: <72eea96c-8ad0-90b0-aaa7-dabad1f118d8@redhat.com> Date: Fri, 18 Sep 2020 12:24:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200918112909.5f797bf4.cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 01:32:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, thuth@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Connie, On 9/18/20 11:29 AM, Cornelia Huck wrote: > On Tue, 8 Sep 2020 21:33:09 +0200 > Eric Auger wrote: > >> Commit 9b3a35ec82 ("virtio: verify that legacy support is not >> accidentally on") added a safety check that requires to set >> 'disable-legacy=on' on virtio-iommu-pci: >> >> qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, >> use disable-legacy=on >> >> virtio-iommu was introduced after the release of VIRTIO 1.0 >> specifications, so it should be 'modern-only'. >> >> This patch forces virtio version 1 and removes the 'transitional_name' >> property removing the need to specify 'disable-legacy=on' on >> virtio-iommu-pci device. > > Not sure whether this patch has been queued already, and how much we > care about migration compatibility for virtio-iommu, but would it make > sense to force modern on 5.1+ compat machines only? (see > https://lore.kernel.org/qemu-devel/20200918074710.27810-1-sgarzare@redhat.com/) I don't think it was pulled yet. > >> >> Cc: qemu-stable@nongnu.org The virtio-iommu-pci device only is usable on ARM in dt mode so I don't think it has production users at the moment. Thanks Eric >> Signed-off-by: Eric Auger >> Reviewed-by: Cornelia Huck >> >> --- >> v1 -> v2: >> - Added Connie's R-b >> --- >> hw/virtio/virtio-iommu-pci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c >> index ba62d60a0a..3b6f7a11c6 100644 >> --- a/hw/virtio/virtio-iommu-pci.c >> +++ b/hw/virtio/virtio-iommu-pci.c >> @@ -68,6 +68,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp) >> object_property_set_link(OBJECT(dev), "primary-bus", >> OBJECT(pci_get_bus(&vpci_dev->pci_dev)), >> &error_abort); >> + virtio_pci_force_virtio_1(vpci_dev); >> qdev_realize(vdev, BUS(&vpci_dev->bus), errp); >> } >> >> @@ -97,7 +98,6 @@ static void virtio_iommu_pci_instance_init(Object *obj) >> static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = { >> .base_name = TYPE_VIRTIO_IOMMU_PCI, >> .generic_name = "virtio-iommu-pci", >> - .transitional_name = "virtio-iommu-pci-transitional", >> .non_transitional_name = "virtio-iommu-pci-non-transitional", >> .instance_size = sizeof(VirtIOIOMMUPCI), >> .instance_init = virtio_iommu_pci_instance_init, > >