Re: [PATCH 2/3] NFSD: Include <linux/nfs_fh.h> where struct nfs_fh is used

[Jeff Layton <jlayton@kernel.org>]

On Tue, 2026-08-18 at 10:00 -0400, Chuck Lever wrote:
> struct nfsd4_copy embeds a struct nfs_fh, and nlm_fopen() reads the
> size and data fields of one. Neither fs/nfsd/xdr4.h nor
> fs/nfsd/lockd.c includes the header that defines the type; both
> reach it by way of nfsd.h, which pulls in <linux/nfs.h>.
> 
> Add the direct include to both files, so nfsd.h can later drop the
> <linux/nfs.h> it carries for no use of its own.
> 
> Signed-off-by: Chuck Lever <cel@kernel.org>
> ---
>  fs/nfsd/lockd.c | 1 +
>  fs/nfsd/xdr4.h  | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/fs/nfsd/lockd.c b/fs/nfsd/lockd.c
> index 5ec0f5456063..f24e45dc37a0 100644
> --- a/fs/nfsd/lockd.c
> +++ b/fs/nfsd/lockd.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/file.h>
>  #include <linux/lockd/bind.h>
> +#include <linux/nfs_fh.h>
>  #include "nfsd.h"
>  #include "nfserr.h"
>  #include "vfs.h"
> diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h
> index 7bbb375874ef..b841bc462dac 100644
> --- a/fs/nfsd/xdr4.h
> +++ b/fs/nfsd/xdr4.h
> @@ -37,6 +37,8 @@
>  #ifndef _LINUX_NFSD_XDR4_H
>  #define _LINUX_NFSD_XDR4_H
>  
> +#include <linux/nfs_fh.h>
> +
>  #include "state.h"
>  #include "vfs.h"
>  

Reviewed-by: Jeff Layton <jlayton@kernel.org>