All of lore.kernel.org
 help / color / mirror / Atom feed
From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH v2 1/7] nvmet: add transport discovery change op
Date: Wed, 29 May 2019 15:27:36 -0700	[thread overview]
Message-ID: <72f17092-e068-a13c-9088-59afafcd6157@gmail.com> (raw)
In-Reply-To: <5e71e7be-3ce0-aa3f-4456-7a6d454a3c7d@grimberg.me>

On 5/29/2019 3:21 PM, Sagi Grimberg wrote:
> 
>> diff --git a/drivers/nvme/target/discovery.c 
>> b/drivers/nvme/target/discovery.c
>> index 5baf269f3f8a..8efca26b4776 100644
>> --- a/drivers/nvme/target/discovery.c
>> +++ b/drivers/nvme/target/discovery.c
>> @@ -41,6 +41,10 @@ void nvmet_port_disc_changed(struct nvmet_port *port,
>> ????????? __nvmet_disc_changed(port, ctrl);
>> ????? }
>> ????? mutex_unlock(&nvmet_disc_subsys->lock);
>> +
>> +??? /* If transport can signal change, notify transport */
>> +??? if (port->tr_ops && port->tr_ops->discovery_chg)
>> +??????? port->tr_ops->discovery_chg(port);
> 
> So you are shooting for both transport and disc aen to happen
> at the same time?

they could if the discovery controller is a persistent one.

-- james

  reply	other threads:[~2019-05-29 22:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 21:58 [PATCH v2 0/7] nvmet/nvmet_fc: add events for discovery controller rescan James Smart
2019-05-14 21:58 ` [PATCH v2 1/7] nvmet: add transport discovery change op James Smart
2019-05-29 22:21   ` Sagi Grimberg
2019-05-29 22:27     ` James Smart [this message]
2019-05-29 22:42       ` Sagi Grimberg
2019-05-29 22:58         ` James Smart
2019-05-30  1:04           ` Sagi Grimberg
2019-05-14 21:58 ` [PATCH v2 2/7] nvmet_fc: add transport discovery change event callback support James Smart
2019-05-14 21:58 ` [PATCH v2 3/7] nvme-fcloop: Add support for nvmet discovery_event op James Smart
2019-05-14 21:58 ` [PATCH v2 4/7] lpfc: Add support to generate RSCN events for nport James Smart
2019-05-14 21:58 ` [PATCH v2 5/7] lpfc: add nvmet discovery_event op support James Smart
2019-05-14 21:58 ` [PATCH v2 6/7] lpfc: Add support for translating an RSCN rcv into a discovery rescan James Smart
2019-05-14 21:58 ` [PATCH v2 7/7] lpfc: Add sysfs interface to post NVME RSCN James Smart
2019-05-29 23:12 ` [PATCH v2 0/7] nvmet/nvmet_fc: add events for discovery controller rescan Arun Easi
2019-05-30 18:04   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72f17092-e068-a13c-9088-59afafcd6157@gmail.com \
    --to=jsmart2021@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.