From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wu, Jingjing" <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 5/7] fix the Marco conflict
Date: Thu, 28 Aug 2014 10:55:55 +0200 [thread overview]
Message-ID: <7302306.qBW1xKV0E1@xps13> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8ADBF1D-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 03:39, Wu, Jingjing:
> Because these macros such as IPPROTO_TCP, IPPROTO_UDP are already
> defined in <netinet/in.h>. If user's application include <netinet/in.h>
> and rte_ip.h at the same time, there will be conflict error, for
> example cmdline.c in testpmd.
Yes
> I remember there was someone also raised this issue few month ago.
Yes, and the question was: "should we totally remove these definitions"?
I think yes.
> So just use the way "#ifndef #endif" to avoid the conflict.
But you didn't explain difference between _NETINET_IN_H and _NETINET_IN_H_.
> And it is exactly workaround as you said.
Yes, it's a workaround.
If rte_ip.h is included before netinet/in.h, I think there is still a problem.
--
Thomas
next prev parent reply other threads:[~2014-08-28 8:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 2:13 [PATCH v2 0/7] Support flow director programming on fortville Jingjing Wu
[not found] ` <1409105634-29980-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 2:13 ` [PATCH v2 1/7] i40e: flow director resource reserve and initialize on i40e Jingjing Wu
[not found] ` <1409105634-29980-2-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 14:17 ` Thomas Monjalon
2014-08-28 2:56 ` Wu, Jingjing
2014-08-27 2:13 ` [PATCH v2 2/7] ethdev: define new ethdev API rx_classification_filter_ctl Jingjing Wu
[not found] ` <1409105634-29980-3-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 14:22 ` Thomas Monjalon
2014-08-28 3:30 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADBEF0-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 10:55 ` Thomas Monjalon
2014-08-28 11:48 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772582135F39F-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 14:07 ` Wu, Jingjing
2014-08-28 13:39 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADC20D-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 14:20 ` Thomas Monjalon
2014-08-28 14:31 ` Wu, Jingjing
2014-08-27 2:13 ` [PATCH v2 3/7] i40e: function implement in i40e for flow director filter programming Jingjing Wu
[not found] ` <1409105634-29980-4-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 14:24 ` Thomas Monjalon
2014-08-28 2:57 ` Wu, Jingjing
2014-08-27 2:13 ` [PATCH v2 4/7] i40e: function implement in i40e for flow director flush and info get Jingjing Wu
2014-08-27 2:13 ` [PATCH v2 5/7] fix the Marco conflict Jingjing Wu
[not found] ` <1409105634-29980-6-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 14:27 ` Thomas Monjalon
2014-08-28 3:39 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADBF1D-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 8:55 ` Thomas Monjalon [this message]
2014-08-28 14:37 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADC286-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 14:46 ` Thomas Monjalon
2014-08-27 2:13 ` [PATCH v2 6/7] i40e: support FD ID report and match counter for i40e flow director Jingjing Wu
2014-08-27 2:13 ` [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support Jingjing Wu
[not found] ` <1409105634-29980-8-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 14:35 ` Thomas Monjalon
2014-08-27 16:54 ` Venkatesan, Venky
2014-08-28 3:51 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADBF4E-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 8:50 ` Thomas Monjalon
2014-08-28 9:01 ` Wu, Jingjing
[not found] ` <9BB6961774997848B5B42BEC655768F8ADC10D-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 11:00 ` Thomas Monjalon
2014-08-28 11:30 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772582135F37F-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-28 12:02 ` Thomas Monjalon
2014-09-24 4:52 ` [PATCH v2 0/7] Support flow director programming on fortville Cao, Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7302306.qBW1xKV0E1@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.