From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dphNn-0004el-JQ for mharc-grub-devel@gnu.org; Wed, 06 Sep 2017 16:57:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dphNl-0004cD-7M for grub-devel@gnu.org; Wed, 06 Sep 2017 16:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dphNh-0000wd-BK for grub-devel@gnu.org; Wed, 06 Sep 2017 16:57:09 -0400 Received: from mga05.intel.com ([192.55.52.43]:24177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dphNh-0000wB-0W for grub-devel@gnu.org; Wed, 06 Sep 2017 16:57:05 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 06 Sep 2017 13:57:03 -0700 Message-Id: <7327ef$3ubqpm@orsmga002.jf.intel.com> X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,355,1500966000"; d="scan'208";a="132508472" Received: from jbkonno-tarlowe.jf.intel.com ([10.54.75.23]) by orsmga002.jf.intel.com with ESMTP; 06 Sep 2017 13:57:03 -0700 Date: Wed, 6 Sep 2017 13:56:57 -0700 From: Joe Konno To: grub-devel@gnu.org Cc: david.e.box@intel.com Subject: Re: [PATCH] tsc: Change default tsc calibration method to EFI on EFI systems In-Reply-To: <20170906202054.2214-1-david.e.box@linux.intel.com> References: <20170906202054.2214-1-david.e.box@linux.intel.com> Organization: Intel Corporation MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/J/N9H0ZQ8IAV3VBI9dvq40d"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.43 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 20:57:10 -0000 --Sig_/J/N9H0ZQ8IAV3VBI9dvq40d Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 6 Sep 2017 13:20:54 -0700 "David E. Box" wrote: > On efi systems, make efi based tsc calibration the default, followed by > the pmtimer before using the pit. This prevents Grub boot failure on > newer x86 systems that power gate the pit. >=20 > Signed-off-by: David E. Box > --- > grub-core/kern/i386/tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/grub-core/kern/i386/tsc.c b/grub-core/kern/i386/tsc.c > index 2e85289d8..de4057ddb 100644 > --- a/grub-core/kern/i386/tsc.c > +++ b/grub-core/kern/i386/tsc.c > @@ -68,7 +68,7 @@ grub_tsc_init (void) > #ifdef GRUB_MACHINE_XEN > (void) (grub_tsc_calibrate_from_xen () || calibrate_tsc_hardcode()); > #elif defined (GRUB_MACHINE_EFI) > - (void) (grub_tsc_calibrate_from_pit () || grub_tsc_calibrate_from_pmti= mer () || grub_tsc_calibrate_from_efi() || calibrate_tsc_hardcode()); > + (void) (grub_tsc_calibrate_from_efi () || grub_tsc_calibrate_from_pmti= mer () || grub_tsc_calibrate_from_pit () || calibrate_tsc_hardcode()); > #elif defined (GRUB_MACHINE_COREBOOT) > (void) (grub_tsc_calibrate_from_pmtimer () || grub_tsc_calibrate_from_= pit () || calibrate_tsc_hardcode()); > #else Good catch! Noted the baked-in, minor style cleanup: grub_tsc_calibrate_from_efi() -> grub_tsc_calibrate_from_efi () You have my: Reviewed-by: Joe Konno Cheers --Sig_/J/N9H0ZQ8IAV3VBI9dvq40d Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkQ//qyfF7ERwiWhKjYhH1S9KqmYFAlmwYRkACgkQjYhH1S9K qmZSgg//fYKo7cLb9QX9NL0yHpLRUslz1qgXZCpWTJzWmV/MZDzdFu39GLV6zcI5 ffGwlT5eBICpe6e8Sr/HGvyNCMI3/96YTOVxLENtOQJSgV7SMazV9kQ0PwEX413I B0aSAu+QUvB0doOU+5kpxXs+0NvQsJgEdhuGXIYrGxCukiQNEOPPXfuXl8cu5tq2 642/MVta9tR7Joh/6lj0adHj4g2q2o2i0KPtf3AyJB0hHKObScGet18F3hJYfbqF xs2mw7QI5aIZOu+SGPXX9OJWQ0xZuJktFYw4fxBwky48U6eJ3oZz0titZ6sFYmMD Zn/k4C09vj1NeTGE8XovhvalYAT80StuE8TfbBkM+RCTzSL/NmKJ/UV/nh3AdzsZ s+EufNTXUt8/0EIWvLH9V2pJzEdHXw2aZX107MuTfx43fgvW2Ng6O2hBYgL3cUt7 pZBbnRT3sGp0z+vW3020SJ2TKt/fkMr+snD4AGoPS5QvcvI6r8xyNnl5VvI3toWc XYP5i/r7mhRzANF0TAuzVqnXRD/8BKkUYtydqHQ62q1vaZ/XG34OPICUk7KB47AO naypVylG4Ze1dQE1IK/CSfUs/ge/5o+9L5+ck2/yYJNNbuCO2mNazUx3z4MPigzR Lc8g4732McEAiw6lVPP7+exBAu8v6E/g954qFLlizKq72lr5so4= =r3ny -----END PGP SIGNATURE----- --Sig_/J/N9H0ZQ8IAV3VBI9dvq40d--