From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58900 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBbEp-0000S0-9O
	for qemu-devel@nongnu.org; Mon, 10 May 2010 18:14:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OBbEo-0008N2-3j
	for qemu-devel@nongnu.org; Mon, 10 May 2010 18:14:11 -0400
Received: from mail.gmx.net ([213.165.64.20]:53875)
	by eggs.gnu.org with smtp (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OBbEn-0008Mn-OD
	for qemu-devel@nongnu.org; Mon, 10 May 2010 18:14:10 -0400
Message-ID: <732842FC0B2147898A4875AF03600054@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <1273492519-15443-1-git-send-email-qiaochong@loongson.cn>
	<EE113751-084F-4AF9-B5AB-FDFE43F06B9B@suse.de>
In-Reply-To: <EE113751-084F-4AF9-B5AB-FDFE43F06B9B@suse.de>
Date: Tue, 11 May 2010 00:13:10 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, QiaoChong <qiaochong@loongson.cn>
Cc: joro@8bytes.org, qemu-devel@nongnu.org, elek.roland@gmail.com

Alexander Graf wrote:
> Hi Chong,
>
> On 10.05.2010, at 13:55, QiaoChong wrote:
>
> > When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register.
> > Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media.
> > I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a little,then the cdrom can be identified,and 
> > read by os.
> > If qemu can change dma_buf_prepare,dma_buf_rw,dma_buf_commit to a function pointer in BMDMAState,then I can rewrite 
> > three functions to support ahci's prtd,because it is different from ide's.
> >
> > test a sata disk like this:
> > ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk
> > test a sata cd like this:
> > ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive 
> > if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso
>
> Thanks for improving the patch, but I have some nitpicks considering on how to process here.
>
> For starters, this patch is incremental to the previous one. Since the previous patch did not get applied to qemu, it 
> doesn't make sense to send an incremental patch. Please send the full patchset but bump up > the version in that case. 
> You will find many examples for that on the mailing list. In most cases it also makes sense to rethink the splitting 
> between patches.

The problem of incremental patches will be a non issue as soon as the git tree is available.

Sebastian