From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] quotactl01: replace int comparison with memcmp
Date: Mon, 16 Jan 2017 08:33:30 -0500 (EST) [thread overview]
Message-ID: <736460527.3439715.1484573610899.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170116115056.GB23274@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it, "yangx jy" <yangx.jy@cn.fujitsu.com>
> Sent: Monday, 16 January, 2017 12:50:57 PM
> Subject: Re: [PATCH] quotactl01: replace int comparison with memcmp
>
> Hi!
> > - memset(fmt_buf, 0, sizeof(fmt_buf));
> > + memset(&fmt_buf, 0, sizeof(fmt_buf));
>
> Hmm, we can simply do fmt_buf = 0 here now, right?
Replaced with simple assignment and pushed.
Regards,
Jan
>
> Otherwise this looks good, acked.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2017-01-16 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 11:43 [LTP] [PATCH] quotactl01: replace int comparison with memcmp Jan Stancek
2017-01-16 2:13 ` Xiao Yang
2017-01-16 11:50 ` Cyril Hrubis
2017-01-16 13:33 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=736460527.3439715.1484573610899.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.