Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04

[Derrick Stolee <derrickstolee@github.com>]

On 8/24/22 7:43 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Derrick Stolee <derrickstolee@github.com>
>>
>> GitHub Actions scheduled a brownout of Ubuntu 18.04, which canceled all
>> runs of the 'static-analysis' job in our CI runs. Update to 22.04 to
>> avoid this as the brownout later turns into a complete deprecation.
>>
>> The use of 18.04 was set in d051ed77ee6 (.github/workflows/main.yml: run
>> static-analysis on bionic, 2021-02-08) due to the lack of Coccinelle
>> being available on 20.04 (which continues today).
>>
>> Signed-off-by: Derrick Stolee <derrickstolee@github.com>
>> ---
>>     ci: update 'static-analysis' to Ubuntu 20.04
>>     
>>     I noticed this while preparing my bundle URIs series. See an example
>>     cancellation at [1]
>>     
>>     [1]
>>     https://github.com/gitgitgadget/git/runs/7954913465?check_suite_focus=true
>>     
>>     I initially asked about this [2]. Thanks to Matthias Aßhauer for
>>     pointing out that 22.04 has Coccinelle available [3].
> 
> Thanks, it is already paying its dividend, it seems.
> 
> We probably need to fix or revert/remove rules we have in
> unused.cocci that makes bogus "suggestion".
> 
>   https://github.com/git/git/runs/8005321972?check_suite_focus=true

Yes, this is definitely a bogus suggestion. It's probable that it
is picked up by the newer version of Coccinelle.

I would recommend removing unused.cocci in a patch after this one,
and then you can apply both into 'maint'.

Perhaps a careful rewrite of unused.cocci could fix these kind of
suggestions using the latest version of Coccinelle, but now is not
the time to wait for that.

Thanks,
-Stolee