All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Mirko Faina" <mroik@delayed.space>, git@vger.kernel.org
Subject: Re: [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total)
Date: Mon, 23 Mar 2026 11:29:21 +0100	[thread overview]
Message-ID: <73663cf1-3112-4e8c-a6ab-10a30670d355@app.fastmail.com> (raw)
In-Reply-To: <7b1e5cbb243cf3421a4affd77bb45d31f3e7146c.1773959395.git.mroik@delayed.space>

On Thu, Mar 19, 2026, at 23:38, Mirko Faina wrote:
> When --commit-list-format has been introduced to format-patch, two new

The past tense here is wrong.

s/has been/was/

> placeholders have been added to the PRETTY FORMATS code without being

s/have been/were/

> documented. Do so now.
>
> Signed-off-by: Mirko Faina <mroik@delayed.space>
> ---
>  Documentation/pretty-formats.adoc | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/pretty-formats.adoc
> b/Documentation/pretty-formats.adoc
> index 5405e57a60..67dc0f2a82 100644
> --- a/Documentation/pretty-formats.adoc
> +++ b/Documentation/pretty-formats.adoc
> @@ -253,6 +253,10 @@ The placeholders are:
>  	linkgit:git-rev-list[1])
>  +%d+:: ref names, like the --decorate option of linkgit:git-log[1]
>  +%D+:: ref names without the " (", ")" wrapping.
> ++%(count)+:: the number of a patch within a patch series. Used only in
> +	`--commit-list-format` in `format-patch`
> ++%(total)+:: the number of tatal patches in a patch series. Used only

s/the number of tatal patches/the total number of patches/ ?

> in
> +	`--commit-list-format` in `format-patch`
>  ++%(decorate++`[:<option>,...]`++)++::
>  ref names with custom decorations. The `decorate` string may be
> followed by a
>  colon and zero or more comma-separated options. Option values may
> contain
> --
> 2.53.0.1018.g2bb0e51243

  reply	other threads:[~2026-03-23 10:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 23:20 [PATCH 0/7] improve "git format-patch --commit-list-format" Mirko Faina
2026-03-14 23:20 ` [PATCH 1/7] pretty.c: better die message %(count) and %(total) Mirko Faina
2026-03-14 23:20 ` [PATCH 2/7] format-patch: refactor generate_commit_list_cover Mirko Faina
2026-03-14 23:20 ` [PATCH 3/7] format-patch: rename --cover-letter-format option Mirko Faina
2026-03-14 23:20 ` [PATCH 4/7] format.commitListFormat: strip meaning from empty Mirko Faina
2026-03-14 23:20 ` [PATCH 5/7] format-patch: wrap generate_commit_list_cover() Mirko Faina
2026-03-17 15:32   ` Kristoffer Haugsbakk
2026-03-17 16:18     ` Mirko Faina
2026-03-14 23:20 ` [PATCH 6/7] format-patch: add preset for --commit-list-format Mirko Faina
2026-03-14 23:20 ` [PATCH 7/7] format-patch: --commit-list-format without prefix Mirko Faina
2026-03-17 15:29   ` Kristoffer Haugsbakk
2026-03-17 16:20     ` Mirko Faina
2026-03-19 22:38 ` [PATCH v2 0/8] improve "git format-patch --commit-list-format" Mirko Faina
2026-03-19 22:38   ` [PATCH v2 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina
2026-03-19 22:38   ` [PATCH v2 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina
2026-03-19 22:38   ` [PATCH v2 3/8] format-patch: rename --cover-letter-format option Mirko Faina
2026-03-19 22:38   ` [PATCH v2 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina
2026-03-23 10:29     ` Kristoffer Haugsbakk [this message]
2026-03-23 14:00       ` Mirko Faina
2026-03-19 22:38   ` [PATCH v2 5/8] format.commitListFormat: strip meaning from empty Mirko Faina
2026-03-19 22:38   ` [PATCH v2 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina
2026-03-19 22:38   ` [PATCH v2 7/8] format-patch: add preset for --commit-list-format Mirko Faina
2026-03-19 22:38   ` [PATCH v2 8/8] format-patch: --commit-list-format without prefix Mirko Faina
2026-03-23 16:57   ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Mirko Faina
2026-03-23 16:57     ` [PATCH v3 1/8] pretty.c: better die message %(count) and %(total) Mirko Faina
2026-03-23 16:57     ` [PATCH v3 2/8] format-patch: refactor generate_commit_list_cover Mirko Faina
2026-03-23 16:57     ` [PATCH v3 3/8] format-patch: rename --cover-letter-format option Mirko Faina
2026-03-23 16:57     ` [PATCH v3 4/8] docs/pretty-formats: add %(count) and %(total) Mirko Faina
2026-03-23 16:57     ` [PATCH v3 5/8] format.commitListFormat: strip meaning from empty Mirko Faina
2026-03-23 16:57     ` [PATCH v3 6/8] format-patch: wrap generate_commit_list_cover() Mirko Faina
2026-03-23 16:57     ` [PATCH v3 7/8] format-patch: add preset for --commit-list-format Mirko Faina
2026-03-23 16:57     ` [PATCH v3 8/8] format-patch: --commit-list-format without prefix Mirko Faina
2026-03-23 20:10     ` [PATCH v3 0/8] improve "git format-patch --commit-list-format" Junio C Hamano
2026-03-24 16:19       ` Kristoffer Haugsbakk
2026-03-26 14:29       ` Phillip Wood
2026-03-26 16:37         ` Junio C Hamano
2026-03-27  1:13           ` Mirko Faina
2026-03-27 16:04             ` Junio C Hamano
2026-03-27 16:18               ` Mirko Faina
2026-03-27 16:47                 ` Junio C Hamano
2026-03-26 16:34     ` D. Ben Knoble
2026-03-26 17:15       ` Mirko Faina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73663cf1-3112-4e8c-a6ab-10a30670d355@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=mroik@delayed.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.