From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen packets
Date: Thu, 1 Apr 2021 07:45:31 +0000 [thread overview]
Message-ID: <73740cc758ee4998b4035ebda838453f@intel.com> (raw)
In-Reply-To: <BN8PR11MB3795C1214B25C3D7D0ABE66FF77B9@BN8PR11MB3795.namprd11.prod.outlook.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Thursday, April 1, 2021 2:16 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter for badlen
> packets
>
> > -----Original Message-----
> > From: Zhang, AlvinX <alvinx.zhang@intel.com>
> > Sent: Thursday, April 1, 2021 13:22
> > To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] net/e1000: fix Rx error counter for badlen packets
> >
> > When the size of a packet in Rx channel is less than the minimum or
> > greater than the maximum, the packet will be simultaneously counted by
> > RLEC(Receive Length Error Count) and RUC(Receive Under Size
> > Count)/ROC(Receive Oversize Count) registers.
> >
> > This patch fixes the issue of counting a length error packet twice
> > when counting the total number of received error packets.
> >
> > Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc
> > and badlen packets")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >
> > V2: Refine commit log
> > ---
> > drivers/net/e1000/em_ethdev.c | 3 +--
> > drivers/net/e1000/igb_ethdev.c | 3 +--
> > 2 files changed, 2 insertions(+), 4 deletions(-)
> >
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
> > --
> > 1.8.3.1
prev parent reply other threads:[~2021-04-01 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 1:17 [dpdk-dev] [PATCH] net/e1000: fix Rx error counters for badlen packets Alvin Zhang
2021-04-01 5:08 ` [dpdk-dev] [PATCH v2] net/e1000: fix Rx error counter " Alvin Zhang
2021-04-01 5:21 ` Alvin Zhang
2021-04-01 6:16 ` Wang, Haiyue
2021-04-01 7:45 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73740cc758ee4998b4035ebda838453f@intel.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.