From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Gruenbacher <agruenba@redhat.com>
Date: Fri, 6 Feb 2015 18:50:47 -0500 (EST)
Subject: [Cluster-devel] 3.18.5 kernel panic: fs/gfs2/acl.c:76
In-Reply-To: <m2bnl6hhco.fsf@discipline.rit.edu>
References: <m2bnl6hhco.fsf@discipline.rit.edu>
Message-ID: <73758762.196941.1423266647719.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Andrew,

> 3.18.5 kernel crashing on acl deletion:
> 
> null pointer dereference in fs/gfs2/acl.c:76

this bug seems to exist since commit 2646a1f6 from October 2009.

> fix we're using currently:
> 
> ---
>  fs/gfs2/acl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
> index 3088e2a..8339754 100644
> --- a/fs/gfs2/acl.c
> +++ b/fs/gfs2/acl.c
> @@ -73,7 +73,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl
> *acl, int type)
>  
>         BUG_ON(name == NULL);
>  
> -       if (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
> +       if ((acl) && (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode))))
>                 return -E2BIG;
>  
>         if (type == ACL_TYPE_ACCESS) {

Except for the extra parentheses this seems correct, thank you.

Andreas