From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC5BC0015E for ; Mon, 3 Jul 2023 15:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbjGCP14 (ORCPT ); Mon, 3 Jul 2023 11:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjGCP1z (ORCPT ); Mon, 3 Jul 2023 11:27:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A4C9E70; Mon, 3 Jul 2023 08:27:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C0E360F53; Mon, 3 Jul 2023 15:27:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C99FC433C8; Mon, 3 Jul 2023 15:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688398072; bh=6JElBzuIBOpjOrTnPoZBAhdfC4cekLjJpRnVZgfMtvo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pUEOBkgMhDCgUoT7ntwgcBP7ZbZ2CRQd6gozFg8DovqLMWXSsaMEEY3Ytnwldyd++ 6eR+kd382Awwg+xDxlpQ4/ID3HLPgvfSlqZGCYms+672b1Cja4AtAfDeX3E8EsQ4iX 7QoLS7qBNQVzZVYt42DIlttF3VqAvCeojABD4neehHycqGr4C4MP9OBpT1+oJqUCVp GYVzlRIp9iBO8d84QmFxghMyg9w6HhghOCkR7/7fSwZSf3O2Ms2j0e0Ek3G8u83GpJ RdwbQzwHGMurT6uwBXQWot/nxB+OpOk25dlcVFlsUguMDhtMGUmJqxv9nO4CMy8POG 3io9xuvNgE70Q== Message-ID: <73a4545a-e149-261a-a0c5-a526e8740bd5@kernel.org> Date: Mon, 3 Jul 2023 18:27:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 0/3] Configure usb0 as peripheral on am335x boards Content-Language: en-US To: Julien Panis , Tony Lindgren Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, nm@ti.com, Tom Rini References: <20230629-usb0-as-peripheral-v1-0-167f78a11746@baylibre.com> <20230630072047.GK14287@atomide.com> <7f44798b-e2bf-1620-da37-ca13bfd07a21@kernel.org> <9ef45899-c766-e839-522a-3b048f8106f7@kernel.org> <6a51d860-2d20-6c35-3935-985d5b41853e@baylibre.com> From: Roger Quadros In-Reply-To: <6a51d860-2d20-6c35-3935-985d5b41853e@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 03/07/2023 17:14, Julien Panis wrote: > On 7/3/23 15:44, Roger Quadros wrote: >> >> On 03/07/2023 14:56, Julien Panis wrote: >>> On 6/30/23 21:40, Roger Quadros wrote: >>>> Hi, >>>> >>>> On 30/06/2023 11:30, Julien Panis wrote: >>>>> Hello Tony, >>>>> >>>>> On 6/30/23 09:20, Tony Lindgren wrote: >>>>>> Hi, >>>>>> >>>>>> * Julien Panis [230629 13:10]: >>>>>>> This series configures usb0 dr_mode as 'peripheral' for am335x-evm, >>>>>>> am335x-evmsk, and am335x-icev2. This USB port is mainly used for >>>>>>> RNDIS and DFU. >>>>>> Is this a mini-B connector? Just wondering if it was originally attempted >>>>>> to be configured as OTG or how it ended up with a host configuration.. >>>>> It's a micro USB-AB connector. >>>>> I don't know how it ended up with a host configuration, it looks like an oversight. >>>>> Maybe Vignesh or Nishanth can confirm (?) >>>> usb0 role should be "otg". >>>> It is rightly so in Linux DT. am33xx.dtsi contains "otg" and all AM335x board files inherit from it. >>>> >>>> So I don't think setting it to "peripheral" in u-boot is the right thing to do. >>> This series is for kernel (not for u-boot). >>> Why is it a problem to set usb0 as 'peripheral' in kernel for the 3 board dts ? >>> >>> With usb0 not set as 'peripheral', the 3 boards (am335x-evm, evm-sk, icev2) >>> do not boot with uboot 2023.04. This error is returned, with LOG_LEVEL=5: >>>      No USB device found >>>      USB ether init failed >>>      initcall sequence 8ffdbba4 failed at call 808024d9 (err=-19) >>>      ### ERROR ### Please RESET the board ### >>> This error is also returned with usb0 as 'otg'. >> This error is at u-boot correct? This will need further investigation. >> >> Does it function correctly in Linux when kept as 'otg'? >> > > This error is at u-boot level, indeed. I add Tom Rini to this thread, since he > was involved in the discussion here: > https://lore.kernel.org/all/20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@baylibre.com/ > If dr_mode is set as 'peripheral' in '-u-boot.dtsi' and kept as 'otg' > in linux, it functions correctly in linux. OK. So NAK for this patch series as we don't want to break 'otg' on Linux. u-boot doesn't support 'otg' mode. So we need to force it either to 'peripheral' or 'host'. One solution would be to have 'peripheral' in am335x-*-u-boot.dts? -- cheers, -roger